Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Update chrome.py with default chrome path for AUR installs #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thalissonvs merged 1 commit into autoscrape-labs:main from kajuberdut:patch-1
Aug 19, 2025

Conversation

Copy link
Contributor

@kajuberdut kajuberdut commented Aug 16, 2025 •
edited
Loading

Pull Request

Description

Add google-chrome-stable to browser_paths list to support Arch Linux. This is the default path when using AUR Google Chrome package (https://aur.archlinux.org/packages/google-chrome)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes, no API changes)
  • Performance improvement
  • Tests (adding missing tests or correcting existing tests)
  • Build or CI/CD related changes

How Has This Been Tested?

Ran samples from documentation on CachyOS.

Testing Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • All existing tests pass

Implementation Details

It's a one liner.

API Changes

N/A

Additional Info

N/A

@kajuberdut kajuberdut marked this pull request as draft August 17, 2025 01:08
@kajuberdut kajuberdut marked this pull request as ready for review August 17, 2025 01:16
Copy link
Contributor Author

Sorry, I have little experience with templates like this and definitely did it wrong at first. Hopefully I have done it correctly now (and I fixed the unit tests.)

Copy link
Member

Hi @kajuberdut, thanks for your contribution!

Just a small detail, you have to use the commitizen style for commits, so I can generate the releases. Can you do a force push with the corrected commit messages?
kajuberdut reacted with thumbs up emoji

Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

kajuberdut reacted with thumbs up emoji 

Include `google-chrome-stable` in `browser_paths` so Arch Linux users
with the AUR Google Chrome package are supported. This matches the
default binary name from https://aur.archlinux.org/packages/google-chrome.
Copy link
Contributor Author

Hi @kajuberdut, thanks for your contribution!

Just a small detail, you have to use the commitizen style for commits, so I can generate the releases. Can you do a force push with the corrected commit messages?

I believe I have done this now, re-wrote history a few times because I don't think I rebased off main correctly with the latest changes, but it should now have exactly one squashed commit with a commitizen style message and no unwanted changes.

Copy link
Member

thanks :)

@thalissonvs thalissonvs added the enhancement New feature or request label Aug 19, 2025
@thalissonvs thalissonvs merged commit 94b63b4 into autoscrape-labs:main Aug 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /