Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

JSON serialization of byte and sbyte SmartEnums #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rhssiiy wants to merge 2 commits into ardalis:main
base: main
Choose a base branch
Loading
from rhssiiy:main

Conversation

Copy link

@rhssiiy rhssiiy commented May 28, 2025

Fixes #560
byte and sbyte SmartEnums are supported in serialization by System.Text.Json

simon-hostettler-identitas reacted with hooray emoji
Copy link
Author

rhssiiy commented May 29, 2025

As I mentioned in issue, this is my first PR. If there is anything that would prevent it from being accepted, please don't hesitate to point it out - I will be happy to update or fix it.

I also noticed that the .NET Core workflow is currently broken due to the use of a deprecated actions/upload-artifact@v3. I didn't include a fix for that in this PR to keep the changes focused, but let me know if you'd prefer to include it here - I'd be glad to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SmartEnumValueConverter does not write the value as a number for TValue of type byte or sbyte

1 participant

AltStyle によって変換されたページ (->オリジナル) /