-
Notifications
You must be signed in to change notification settings - Fork 161
Integer midpoint #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Integer midpoint #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci test
@stephentyrone
stephentyrone
force-pushed
the
midpoint
branch
from
July 1, 2024 14:03
5148a09
to
ebda1d2
Compare
glessard
glessard
approved these changes
Jul 2, 2024
@swift-ci please test
Also corrects a typo and makes the deprecated toNearestOrAwayFromZero rule public for migration purposes, and removes the BinaryInteger.midpoint function in favor of the FixedWidthInteger overload. I'm open to reinstating the BI implementation in the future, but let's start with just FWI.
@stephentyrone
stephentyrone
force-pushed
the
midpoint
branch
from
July 22, 2024 18:00
ebda1d2
to
53efe07
Compare
@swift-ci test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Overflow-safe integer midpoint with rounding control
Draft because I am not sold on the free-function spelling
midpoint(a, b)
. It is desirable by symmetry withmin(a, b)
andmax(a, b)
, and because it correctly captures that this is a commutative operation; neither operand is privileged. But Swift generally eschews free functions. This could equally be a static member (Int.midpoint(a, b)
), or possibly use some other spelling.Declaration:
Usage:
Unlike commonly seen expressions such as
(a+b)/2
or(a+b) >> 1
ora + (b-a)/2
(all of which may overflow for fixed-width integers), this function never overflows, and the result is guaranteed to be representable in the result type.The default rounding rule is
.down
, which matches the behavior of(a + b) >> 1
when that expression does not overflow. Rounding.towardZero
matches the behavior of(a + b)/2
when that expression does not overflow. All other rounding modes are supported.