This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

On an abstract level, we originally envisioned @cacheControl as a relatively generic spec rather than something incredibly specific to the implementation in Apollo Server, and so the idea that the permitted values for the argument in the directive in the schema would depend on the implementation of a particular JS-specific third-party package without a formal specification is somewhat uncompelling. eg, it would be challenging to port such a feature to another ecosystem (say, to implement a compatible feature in Rust for Apollo Router) without having to carefully reproduce the semantics of the ms package.

In practice I don't know if these abstract arguments about a subsystem that has not been incredibly actively developed recently should be considered to be more important than more pragmatic approaches, though.

(We chose to have max age mean seconds without a particular unit in the title to match the HTTP cache-control: max-age=123 header, though I think we probably should have put a unit on it anyway.)

@glasser This PR is definitely not a hill I will die on. 😄 This is more of a "convenient DX" more than anything since all it really does is convert it to seconds, which could be done with a calculator anyways. 😅

Happy to close the PR if you are feeling this doesn't add enough value to outweigh the tradeoffs. 😄