-
Notifications
You must be signed in to change notification settings - Fork 2k
Address memory leak in ApolloServerPluginUsageReporting
#7662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6f3412b:
|
@gabotechs based on the Request object you shared, it looks like this is what's leaking (though it's not obvious to me why). This is the only request we send and the URL matches from your object.
Are you able to test out a build from this PR for me and see if the issue goes away?
npm i https://pkg.csb.dev/apollographql/apollo-server/commit/6f3412bd/@apollo/server
I grabbed this URL from the codesandbox link in the comment above. If you're using any other packages from this monorepo it would be preferable to grab them all in the same manner.
WIP attempt to address #7639