-
Notifications
You must be signed in to change notification settings - Fork 875
TIKA-4512 -- first steps #2362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIKA-4512 -- first steps #2362
Conversation
This is just the first step. It won't build fully yet.
I'm using: mvn clean install -am -pl :tika-fetcher-file-system,tika-app -Dcheckstyle.skip -DskipTests
I have this running with only the file system fetcher and tika-app.
I'm struggling with how to configure the plugins. I'd like to move away from our custom serialization stuff. So, now everything depends on jackson-databind, which adds to dependency bloat but makes the code much cleaner.
For now, I'm putting the file-system-fetcher.json
config in the plugin root, and reading it from there. This means that we'll have a bunch of different *.json configs running around, which I don't like.
The current proof of concept only works when using the .jar plugin, not the .zip plugin... ̄_(ツ)_/ ̄
The big change here is that we can't have multiple fetchers of the same class with different configurations like we used to.
However, users can change the configuration of a given fetcher at runtime by passing in the FileSystemFetcherConfig
via the ParseContext.
@nddipiazza would you be willing to take a look and maybe chat?
# Conflicts: # tika-pipes/tika-async-cli/src/main/java/org/apache/tika/async/cli/TikaConfigAsyncWriter.java
Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that
TIKA-XXXX
)[TIKA-XXXX] Issue or pull request title
)mvn clean test
main
branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulledmain
branchtika-bom/pom.xml
.We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!