-
Notifications
You must be signed in to change notification settings - Fork 19.8k
Adds support for changing the tick interval base #21240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.
@Ovilia friendly bump on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change of this PR looks a little complex to me. Would it be simpler if we process the option.series.data
by dividing the original data by 1024 if the max data is less than 1024 * 1024 and use axisLabel.formatter
to add 'KB'
, or by 1024 * 1024 if the max data is less than 1024 * 1024 * 1024 and use axisLabel.formatter
to add 'MB'
... ?
Uh oh!
There was an error while loading. Please reload this page.
Brief Information
This pull request is in the type of:
What does this PR do?
This PR adds the ability to change the base of the tick intervals to align on (1, 2, 3, 4,... * base^x).
Fixed issues
#21208
Details
Before: What was the problem?
When using KMB formatting for a unit that is non base 10 such as binary bytes, the tick intervals will align on a multiple of a base 10 number, so when the formatting occurs the number do not align nicely with the KMB formatting. Setting the interval manually can be difficult/expensive when you have a highly variable, dynamic dataset.
For example, where formatter code looks like so:
After: How does it behave after the fixing?
When using the same formatter but with tickBase = 2
Screenshot 2025年09月02日 at 3 11 35 PMDocument Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information
Let me know what you think! Thanks!