Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(line): correctly stack not-synced time series data. close #15742 #21071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yvanoers wants to merge 1 commit into apache:master
base: master
Choose a base branch
Loading
from yvanoers:fix-15742

Conversation

Copy link

@yvanoers yvanoers commented Jun 27, 2025

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Create correct stacked area chart when it contains time series, regardless of them being disjunct.

Fixed issues

Details

Before: What was the problem?

When stacking time series, echarts decided to use stacking by index.
This causes it to place data in places where it is not: Index 0 for one time series is not necessarily the same point in time as index 0 for another time series.

After: How does it behave after the fixing?

For time series, stacking is set to stacking by dimension and an inverted index is created, allowing stacking to use the time value instead of the index for stacking. It reuses the mechanism for ordinal stacking.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

I added a visual test line-stack-disjunct-timeseries.html.
Please advise whether this should be put in an existing test or can be left stand alone.

All existing visual tests that pass for 6.0.0-beta.1 pass for this PR, however some seem to be flaky. With several runs the flaky ones also pass.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

I have not tested the performance of this on a large dataset.

Copy link

echarts-bot bot commented Jun 27, 2025

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21071@662f14e

Copy link
Author

@Ovilia Any chance this PR be reviewed at by someone any time soon?

@Ovilia Ovilia requested a review from 100pah August 25, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@100pah 100pah Awaiting requested review from 100pah

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /