Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add cache-key as output #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexdunae wants to merge 3 commits into actions:main
base: main
Choose a base branch
Loading
from alexdunae:main
Open

Add cache-key as output #1190

alexdunae wants to merge 3 commits into actions:main from alexdunae:main

Conversation

Copy link

@alexdunae alexdunae commented Jan 14, 2025

Description:
Adds cache-key as an output

Related issue:

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

danwulff, sherif-amk, and ramblingenzyme reacted with heart emoji
@alexdunae alexdunae requested a review from a team as a code owner January 14, 2025 18:42
Copy link

Hi @alexdunae, happy to see this PR.

However, I don't think this would close off #1152, as it doesn't capture if the key of the restored cache is different from the primary key.

Copy link
Author

Hi @alexdunae, happy to see this PR.

However, I don't think this would close off #1152, as it doesn't capture if the key of the restored cache is different from the primary key.

Correct, it was just related but not closing that issue entirely.

I’m happy to add that extra output if it’s of interest?

Copy link
Author

@ramblingenzyme I've added cache-matched-key as well

Copy link

@alexdunae only just seeing this now, I hadn't made the distinction between "relates" and "closes off" when I read the PR description originally.

Thanks for adding the second key though, much appreciated. 🙇🏽

Copy link
Author

@ramblingenzyme no problem. Anything you need to get this merged?

Copy link

@ramblingenzyme ramblingenzyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙇🏽

Copy link
Author

Is it possible to get the second review so this can merge?

Copy link
Author

Circling back on this @ramblingenzyme is there any way to ping another codeowner to get a second review?

Copy link

@alexdunae sorry, I'm not actually a codeowner, not sure how to get their attention either. 😢

Copy link
Contributor

Hello @alexdunae, Thank you for this Pull request. We will review and get back to you once we have some feedback on this :)

ramblingenzyme reacted with hooray emoji ramblingenzyme reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ramblingenzyme ramblingenzyme ramblingenzyme approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /