-
Notifications
You must be signed in to change notification settings - Fork 113
Fixed CsvOutputFormatter bug where a return type was not IEnumerable<T> but is ... #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
preeder
wants to merge
3
commits into
WebApiContrib:master
from
EngageToSellLLC:feature/allow_nongeneric_types_implementing_ienumerable
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...not itself generic (or perhaps not [generic]<T>) would fail when UseSingleLineHeaderInCsv was true.
damienbod
damienbod
previously approved these changes
Apr 10, 2020
Member
damienbod
commented
Apr 10, 2020
@preeder Just want to test and validate this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where a return type which implements IEnumerable but is not itself generic (or perhaps not [generic]) would fail when UseSingleLineHeaderInCsv was true.
This happened to me in .NET Core 3.1 using the pretty simple controller method:
[HttpGet]
[Produces("text/csv")]
public IEnumerable Get(string id)
Perhaps this was caused by how "yield return" is handled by the compiler. I would have looked into that further, except that it was a flaw and fixing the flaw is more important.