Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Incorporate action result executors and a set of helper methods around that #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filipw merged 7 commits into master from feature/actionresults
Feb 16, 2019

Conversation

@filipw
Copy link
Member

@filipw filipw commented Feb 15, 2019
edited
Loading

@khellang this is based on your excellent blog post and modelled after the helper methods on ControllerBase. I did not port the ones that didn't make sense (like *ToAction) or the ones that were simply convenience calls into HttpContext (like Challenge, SignIn and so on).

Since there are plenty of action results that do not have a corresponding executor (most of the simple ones like OkResult or OkObjectResult) those have been adapted accordingly to use HttpResponse directly or other usable results like ObjectResult with modified properties.

Copy link
Member

@khellang khellang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

@filipw filipw merged commit cfb6dee into master Feb 16, 2019
@filipw filipw deleted the feature/actionresults branch February 16, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khellang khellang khellang left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /