-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fixed Text.from_ansi() removing trailing line break. #3793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kmvanbrunt
kmvanbrunt
force-pushed
the
from_ansi_newline
branch
from
July 14, 2025 18:50
3bfa191 to
e54f86e
Compare
@kmvanbrunt
kmvanbrunt
changed the title
(削除) Fixed issue where Text.from_ansi() was removing trailing line breaks. (削除ここまで)
(追記) Fixed issue where Text.from_ansi() was removing ending line break. (追記ここまで)
Jul 14, 2025
@kmvanbrunt
kmvanbrunt
force-pushed
the
from_ansi_newline
branch
from
August 19, 2025 22:03
e54f86e to
adb96f0
Compare
@kmvanbrunt
kmvanbrunt
changed the title
(削除) Fixed issue where Text.from_ansi() was removing ending line break. (削除ここまで)
(追記) Fixed Text.from_ansi() removing a trailing newline. (追記ここまで)
Aug 19, 2025
@kmvanbrunt
kmvanbrunt
force-pushed
the
from_ansi_newline
branch
from
August 19, 2025 22:48
adb96f0 to
7b85447
Compare
@kmvanbrunt
kmvanbrunt
changed the title
(削除) Fixed Text.from_ansi() removing a trailing newline. (削除ここまで)
(追記) Fixed Text.from_ansi() removing a trailing line break. (追記ここまで)
Aug 20, 2025
@kmvanbrunt
kmvanbrunt
force-pushed
the
from_ansi_newline
branch
from
August 20, 2025 02:07
7b85447 to
b5472c9
Compare
@kmvanbrunt
kmvanbrunt
changed the title
(削除) Fixed Text.from_ansi() removing a trailing line break. (削除ここまで)
(追記) Fixed Text.from_ansi() removing trailing line break. (追記ここまで)
Aug 20, 2025
@kmvanbrunt
kmvanbrunt
force-pushed
the
from_ansi_newline
branch
from
August 20, 2025 02:47
b5472c9 to
d89126b
Compare
@kmvanbrunt
kmvanbrunt
force-pushed
the
from_ansi_newline
branch
from
August 20, 2025 02:52
d89126b to
90f3f02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Type of changes
Checklist
Description
Fixes #3577
Ensures that
Text.from_ansi()converts a trailing line break to a newline character instead of removing it.