Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

* fixes issue #1036 #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ps5mh wants to merge 1 commit into Tencent:master from ps5mh:bugfix_GetComponent
Closed

Conversation

Copy link
Contributor

@ps5mh ps5mh commented Jan 30, 2023

  • 需要参考 Unity 2019 引擎源代码中 GetComponent.cpp 的实现
  • 推测 Unity 为了返回的错误信息更详细,这里返回了虽然 == null,但是不是 null 的对象。
  • Unity 引擎仅在 UNITY_EDITOR 宏下如此处理

Copy link
Collaborator

不建议为这种奇怪的设定,产生对unity的依赖。
建议按faq那,用一个C#函数来判断对象有效性。

Copy link
Contributor Author

ps5mh commented Jan 30, 2023

IsNull 比较容易扩散。怕被滥用,项目中大部分情况不推荐同事大面积使用此函数来判断。
GetComponent(typeof(U.Canvas)) 是一个非常基础的用法,如果编辑器和手机表现不同会给人造成混淆。
此修复也只针对UNITY_EDITOR的,我觉得还行呀。

@ps5mh ps5mh closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /