-
Notifications
You must be signed in to change notification settings - Fork 3.4k
bugfix #1648 #1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
bugfix #1648 #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
修复问题 #1648
问题本质原因分析如下:
如上代码在高版本 gradle 配合 agp 中输出:
低版本中没问题,分析发现,高低版本 gradle 依赖的 groovy 版本不一样。
低版本:
groovy.util.XmlParser 内部对应 groovy.xml.QName
groovy.xml.Namespace 内部对应 groovy.xml.QName
所以从 application.attributes() 的 map 中通过 QName key 去获取是可以找到对应 hashkey 的 value。
高版本:
groovy.util.XmlParser 内部对应 groovy.xml.QName
groovy.xml.Namespace 内部对应 groovy.namespace.QName
所以从 application.attributes() 的 map 中通过 QName key 去获取是无法找到对应 hashkey 的 value,因为类名 QName 相同,但是 package name 已经不同了,导致 equals 方法无法相等,除非 XmlParser 也使用 groovy.xml 包下的,但是高版本 groovy 才有这个。
因此修复方案换成 XmlSlurper 即可兼容高低不同版本 groovy。