Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: do not retry transactions on any error #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
laurenceisla wants to merge 6 commits into PostgREST:main
base: main
Choose a base branch
Loading
from laurenceisla:fix/transaction-no-retry

Conversation

Copy link
Member

@laurenceisla laurenceisla commented Jul 23, 2025
edited
Loading

WIP

Should close #3673.

@laurenceisla laurenceisla force-pushed the fix/transaction-no-retry branch 3 times, most recently from 1afa5fb to 665f55c Compare August 13, 2025 01:48
Copy link
Member

Should we vendor hasql-notifications for now since there's no response for diogob/hasql-notifications#30 ?

I remember we did this before too. It's a single file so no major maintenance problem there IMO.

Copy link
Member

We should not vendor it, for two reasons:

  • First of all, we haven't even done our own work, yet. We can't update to hasql 1.8 or 1.9 before the static build is sorted out - and it currently doesn't look like there will be progress soon. The upstream Nixpkgs PR that Build static executable for linux aarch64 (w/ TH) #4193 depends on is likely not going to get merged - and currently Nixpkgs is not even able to build pkgsStatic.libpq anmyore. This only worked by accident. Thus, upgrading to GHC 9.6 and then hasql is quite far out of reach for us right now.
  • 3 weeks without reaction is not "no reaction", imho. Especially when there has been no additional ping in the PR, yet, etc.

@laurenceisla laurenceisla force-pushed the fix/transaction-no-retry branch 2 times, most recently from 510cafa to ff133bf Compare August 13, 2025 13:27
Copy link
Member Author

laurenceisla commented Aug 14, 2025
edited
Loading

3 weeks without reaction is not "no reaction", imho. Especially when there has been no additional ping in the PR, yet, etc.

Thanks for the ping suggestion (I should've done this weeks ago). Changes are now merged and released upstream!

First of all, we haven't even done our own work, yet. We can't update to hasql 1.8 or 1.9 before the static build is sorted out - and it currently doesn't look like there will be progress soon.

OK, so this would be the only blocker for this PR for now then. Also some stack shenanigans, but will fix after this is sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Surprising infinite retrying of SQL statement on a replica causes replication lag

AltStyle によって変換されたページ (->オリジナル) /