-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: do not retry transactions on any error #4222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not retry transactions on any error #4222
Conversation
1afa5fb
to
665f55c
Compare
Should we vendor hasql-notifications for now since there's no response for diogob/hasql-notifications#30 ?
I remember we did this before too. It's a single file so no major maintenance problem there IMO.
We should not vendor it, for two reasons:
- First of all, we haven't even done our own work, yet. We can't update to hasql 1.8 or 1.9 before the static build is sorted out - and it currently doesn't look like there will be progress soon. The upstream Nixpkgs PR that Build static executable for linux aarch64 (w/ TH) #4193 depends on is likely not going to get merged - and currently Nixpkgs is not even able to build
pkgsStatic.libpq
anmyore. This only worked by accident. Thus, upgrading to GHC 9.6 and then hasql is quite far out of reach for us right now. - 3 weeks without reaction is not "no reaction", imho. Especially when there has been no additional ping in the PR, yet, etc.
510cafa
to
ff133bf
Compare
This needs more involved changes in the hsie source code, which can be deferred to later.
ff133bf
to
23426d2
Compare
3 weeks without reaction is not "no reaction", imho. Especially when there has been no additional ping in the PR, yet, etc.
Thanks for the ping suggestion (I should've done this weeks ago). Changes are now merged and released upstream!
First of all, we haven't even done our own work, yet. We can't update to hasql 1.8 or 1.9 before the static build is sorted out - and it currently doesn't look like there will be progress soon.
OK, so this would be the only blocker for this PR for now then. Also some stack
shenanigans, but will fix after this is sorted.
Uh oh!
There was an error while loading. Please reload this page.
WIP
Should close #3673.
hasql
version: Add support for hasql 1.9 diogob/hasql-notifications#30