-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
使用vue-clickaway处理组件外部点击事件 #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... outside of the component, and also make code neat
perf[TagsView]:use vue-clickaway to close context menu when you click...
不觉得这样会简洁,引入新的库感觉会让新手觉得更复杂。本来实现的代码就不复杂,感觉没啥必要。
不觉得这样会简洁,引入新的库感觉会让新手觉得更复杂。本来实现的代码就不复杂,感觉没啥必要。
或许可以直接把Element UI 中的 clickoutside.js 拿过来用
现在的实现方案有什么问题么?
@PanJiaChen 这样写当然没问题,只不过我个人感觉用click-away或者click-outside看上去优雅些
但减少了代码可阅读性,他们看代码还需要先去了解click-away或者click-outside
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tags-view组件引入vue-clickaway处理context menu外部点击事件,控制context menu的visible,让代码更简洁。