-
-
Notifications
You must be signed in to change notification settings - Fork 339
Fix: Improve iterative refinement performance and reduce context explosion #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...osion - Set max_evaluation_tokens default to 2000 (was None) to prevent unbounded context - Use structured findings list instead of formatted text in _evaluate_with_llm - Pass only recent refinement findings to LLM instead of all accumulated context - Constrain refinement prompts to stay focused on original query This fixes: - Context explosion causing slow processing and high token costs - Query drift where refinements diverge from original topic - Excessive LLM context leading to degraded performance
@LearningCircuit
LearningCircuit
requested review from
HashedViking and
djpetti
as code owners
September 25, 2025 21:14
@LearningCircuit
LearningCircuit
changed the base branch from
dev
to
fix/subscriptions-css-classes
September 25, 2025 21:14
@djpetti still draft PR (sorry)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@LearningCircuit
LearningCircuit
added
the
dev-bugfix
Bug fixes for issues found in dev branch
label
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes critical performance issues in the iterative refinement strategy that were causing:
Changes
max_evaluation_tokens
default to 2000 (was None) to prevent unbounded context growth_evaluate_with_llm
to use structured findings list instead of parsing formatted textTesting
Tested with query "What to do against stress?" and observed:
Further Work Needed
While this PR addresses the immediate performance issues, additional improvements should be considered:
Test Results
Before: Queries drifted from "stress reduction" to "verify 13 companies implementing mental health programs"
After: Queries stay focused - "provide evidence-based stress reduction techniques with mechanisms and actionable steps"