-
Notifications
You must be signed in to change notification settings - Fork 5
Fix for Base32 Bug #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
More Details #25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please use spaces instead of tabs for more convenient diff? Other repository files also use spaces.
Sorry If I sound stupid but could you please explain better or may be show me a sample??
pretty new to this pull request thingy.
If you use Visual Studio, click Edit -> Advanced -> View White Space. After that you will be able to see all whitespace characters: whitespaces (⋅⋅⋅⋅) and tabs (→). In this project I use the first ones. But you use the second. So, just replace tabs on whitespaces and make me happy :)
Adjusted to use same formatting as other files in the project.
Thanks for the Information.
Done as Requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a unit test here that not passed with the previous wrong code? I mean your sample with KJXW4YLMMQ====== string.
Added Unit Tests.
Done.
BaseNcoding.Tests/Base32Tests.cs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is a misprint and you mean the following code?
Assert.AreEqual(str, decoded);
BaseNcoding.Tests/Base32Tests.cs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use CamelCase for all words: Base32CompareEncodeAndDecode.
Better name with below comment considering: Base32CompareSourceAndDecoded.
BaseNcoding.Tests/Base32Tests.cs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base32CompareEncodedAndExpected
All Changes Applied as Requested.
Not all :) Please replace Assert.AreEqual(str, encoded); with Assert.AreEqual(str, decoded);.
Lol, Done.
Uh oh!
There was an error while loading. Please reload this page.
More Details #25