Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Let validate check nonempty set for an_element #3959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
schillic wants to merge 2 commits into master
base: master
Choose a base branch
Loading
from schillic/validate_an_element

Conversation

Copy link
Member

@schillic schillic commented Jul 19, 2025 •
edited
Loading

This branch is based on #3961.

isempty is a heavy check and may crash code that worked before.

@schillic schillic force-pushed the schillic/validate_an_element branch 4 times, most recently from f52856a to 0707635 Compare July 19, 2025 13:13
@schillic schillic marked this pull request as ready for review July 19, 2025 13:37
@schillic schillic added the breaking ❌ This change may break things label Jul 19, 2025
@schillic schillic added the discussion 🗣️ Requires human input label Jul 30, 2025
@schillic schillic force-pushed the schillic/validate_an_element branch from 0707635 to 6522520 Compare August 10, 2025 11:08
@schillic schillic marked this pull request as draft August 17, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking ❌ This change may break things discussion 🗣️ Requires human input

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /