-
Notifications
You must be signed in to change notification settings - Fork 6
Implement conversion of Uniform to GeneralQuadratureTable #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement conversion of Uniform to GeneralQuadratureTable #49
Conversation
f6e822a to
ce12ba9
Compare
Not sure what happened with CI here, maybe you can manually re-run it @Andlon?
Not sure what happened with CI here, maybe you can manually re-run it @Andlon?
Hmm, somehow I can't see anything about the CI at all, not sure what's happened here...
ce12ba9 to
d994bdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks useful! Please see comments.
Some very basic tests would also be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, I just still think that with_data_from_fn deserves a simple unit test.
Implements
UniformQuadratureTable::to_general(&self, num_elements)GeneralQuadratureTable::with_data(self, data)