Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

artboard layer drop at bottom #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sahil-Gupta584 wants to merge 1 commit into GraphiteEditor:master
base: master
Choose a base branch
Loading
from Sahil-Gupta584:enhance-artboard-layer-drop

Conversation

Copy link

@Sahil-Gupta584 Sahil-Gupta584 commented Oct 15, 2025

Closes #3256

Demo:

Graphite.-.Personal.2.-.Microsoft_.Edge.2025年10月15日.20-04-11.mp4

Copy link
Member

Keavon commented Oct 15, 2025

Upon watching your video demo, I realized that the ideal behavior will be rejecting the placement opportunity in places that are siblings of artboards (generalized to be describable as "invalid placements"). This would need to be given to the frontend by the backend, or maybe better, answered by the backend in response to a query by the frontend. This way, we never show the white insertion line of a width that would indicate an invalid placement, which is a flaw of this "just correct it if it's invalid" approach that I realized now.

Copy link
Author

Upon watching your video demo, I realized that the ideal behavior will be rejecting the placement opportunity in places that are siblings of artboards (generalized to be describable as "invalid placements"). This would need to be given to the frontend by the backend, or maybe better, answered by the backend in response to a query by the frontend. This way, we never show the white insertion line of a width that would indicate an invalid placement, which is a flaw of this "just correct it if it's invalid" approach that I realized now.

makes sense.
And then what about the feat pr is raised for, it will be valid or invalid drop behaviour ?

Copy link
Member

Keavon commented Oct 17, 2025
edited
Loading

I'd suggest iterating on this PR with the suggested change of approach. No need to open a separate PR.

Copy link
Author

I'd suggest irritating on this PR with the suggested change of approach. No need to open a separate PR.

Can you tell me more clearly what i need to implement? got little confused.

and what about the feat for which pr is raised ?

Copy link
Member

Keavon commented Oct 17, 2025

This PR. I'm suggesting you keep working on changes to it to implement my described updated approach (from my first comment in this discussion).

Copy link
Author

This PR. I'm suggesting you keep working on changes to it to implement my described updated approach (from my first comment in this discussion).

Yes but what about dropping on bottom, should I consider it as valid or invalid now?

Copy link
Member

Keavon commented Oct 18, 2025

I'm not understanding the question. All invalid drop locations shouldn't be valid white horizontal line placements, thus pre-filtering instead of post-rejecting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lazy drag layer(s) to the bottom of the stack if there is only 1 Artboard

AltStyle によって変換されたページ (->オリジナル) /