Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Make new document with doubleclicking on empty tab space #3228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
partg952 wants to merge 21 commits into GraphiteEditor:master
base: master
Choose a base branch
Loading
from partg952:master

Conversation

Copy link

@partg952 partg952 commented Sep 26, 2025 •
edited by timon-schelling
Loading

This is issue number #3215
Make new document with double clicking on empty tab space

Allowing user to create a new file by double clicking on the empty tab space

Recording.2025年09月26日.202723.1.mp4

Closes #3215

alezzacreative reacted with heart emoji
Copy link
Member

Is the issue you have linked correct?

Copy link
Author

Is the issue you have linked correct?

i have fixed it now ,sorry


<LayoutCol on:pointerdown={() => panelType && editor.handle.setActivePanel(panelType)} class={`panel ${className}`.trim()} {classes} style={styleName} {styles}>
<LayoutRow class="tab-bar" classes={{ "min-widths": tabMinWidths }}>
<LayoutRow class="tab-bar" classes={{ "min-widths": tabMinWidths }}on:dblclick={() =>editor.handle.newDocumentDialog()}>
Copy link
Member

@timon-schelling timon-schelling Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add the click handler to a new element that fills the portion of the bar not occupied by tabs, you won’t need to stop event propagation. I think it feels a little cleaner.

Copy link
Author

@partg952 partg952 Sep 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain a little more?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its about making 2 new LayoutCol. Left one should have contain existing document tab and the right one could have on:dblclick=()

Copy link
Member

@timon-schelling timon-schelling Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain a little more?

I mean add a extra child to the tab bar at the end that takes all remaining space.
That child would have the dblclick listener.

Take a look at how I did it in a similar case

<LayoutRow on:mousedown={() => editor.handle.appWindowDrag()} on:dblclick={() => editor.handle.appWindowMaximize()} />

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh okay lemme do it like that

timon-schelling reacted with thumbs up emoji
Copy link
Author

partg952 commented Sep 30, 2025 •
edited
Loading

@timon-schelling can you please take a look at it?

Copy link
Member

@timon-schelling timon-schelling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Copy link
Member

@timon-schelling timon-schelling Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove theses debug changes

Copy link
Author

@partg952 partg952 Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check now

Copy link
Member

@timon-schelling timon-schelling Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've committed more things by accident. In the future before you ping with comment please check yourself if the changes in the File Changes tab of the pr only include what you what to be part of the pr.

Copy link
Author

@partg952 partg952 Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sorry , the pr got quite messy I will make sure of it in the coming pull requests

Copy link
Member

@timon-schelling timon-schelling Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. :)

Copy link
Member

@Keavon Keavon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to wait until I have time to review before it can merge. At a glance, the diff has lots of obvious issues.

Copy link
Member

I will never merge frontend changes without your approval. Just getting them into a state I think you would approve, so you need to spend less time.
Keavon reacted with heart emoji

@timon-schelling timon-schelling marked this pull request as draft October 15, 2025 01:16
Copy link
Member

@partg952 If you are still interested in getting this merged please remove everything from this pr that is not relevant. (Only include the two files you add code in)

Copy link
Author

Oh sure I will do that

Copy link
Author

@timon-schelling can you take a look now i have only included 2 files in the pr now

Copy link
Member

Keavon commented Oct 15, 2025

There are still several extraneous changes in the diff.

Copy link
Author

Lemme fix those too

Copy link
Author

i have undone all the unnecessary edits , please take a look now

Copy link
Member

!build

@partg952 partg952 marked this pull request as ready for review October 16, 2025 18:15
Copy link
Author

@timon-schelling is there anything else i need to do?

Copy link
Member

ci will tell you what is formatted incorrectly. Otherwise LGTM

Copy link
Member

!build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timon-schelling timon-schelling timon-schelling requested changes

@Keavon Keavon Keavon requested changes

+1 more reviewer

@j-jasz j-jasz j-jasz left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make new document with doubleclicking on empty tab space

AltStyle によって変換されたページ (->オリジナル) /