-
-
Notifications
You must be signed in to change notification settings - Fork 956
Fix: check if path tool is interacting with raster layer to prevent crashing. #3182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: check if path tool is interacting with raster layer to prevent crashing. #3182
Conversation
581ff33 to
e8a0e36
Compare
!build
|
Video of the fix:
Graphite.path.tool.bugfix.mov
Please let me know if the video above captures the expected behavior.
This does not remove anchors from the corners of the image. All it does is break the Path tool's ability to select stuff, either a box selection or even clicking on other valid points if multiple layers (including actual vector layers) are selected. Please give it another shot so it addresses the requested change (first sentence of this reply).
So there shouldn't be any anchors displayed on the image at all when the path tool is selected? The path tool still works on the spline as shown, it's just ignoring the raster image.
I added a check before showing the anchors/handles. Please let me know if this PR is in-line with what you expected now.
Okay, I simplified the code changes. I think this PR should fulfill the requirements now.
|
4351bac to
ffc7427
Compare
Resolves #2687
Added a check that returns
PathToolFsmState::Readyif the path tool is used on a raster layer.