Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add setting to select all query text on window reopen #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
1208nn wants to merge 4 commits into Flow-Launcher:dev
base: dev
Choose a base branch
Loading
from 1208nn:add-select-all-query

Conversation

Copy link

@1208nn 1208nn commented Nov 9, 2024

  • SettingsPaneGeneralViewModel.cs

    • Add SelectAllQueryOnReopen property
    • Bind the new property to the settings in the constructor
  • MainWindow.xaml.cs

    • Update OnLoaded method to select all query text if the new setting is enabled
    • Add SelectAllQueryText method to handle selecting all query text
  • MainWindow.xaml

    • Bind QueryTextBox to the new setting to select all query text when the window is reopened
  • SettingWindow.xaml.cs

    • Initialize the new checkbox based on the settings

This comment has been minimized.

Copy link
Member

@1208nn Sorry for the late response. Is there a reason that this is a draft pr?

Copy link
Author

1208nn commented Jan 11, 2025

@1208nn Sorry for the late response. Is there a reason that this is a draft pr?

I'm sorry that I have no touch to those devices that can run VS, so this PR isn't finished as you can see and untested.

* **SettingsPaneGeneralViewModel.cs**
 - Add `SelectAllQueryOnReopen` property
 - Bind the new property to the settings in the constructor
* **MainWindow.xaml.cs**
 - Update `OnLoaded` method to select all query text if the new setting is enabled
 - Add `SelectAllQueryText` method to handle selecting all query text
* **MainWindow.xaml**
 - Bind `QueryTextBox` to the new setting to select all query text when the window is reopened
* **SettingWindow.xaml.cs**
 - Initialize the new checkbox based on the settings

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Member

Jack251970 commented Mar 13, 2025
edited
Loading

@1208nn Hi, I think FL already provides this feature and please check Last Query Style.

image

If you want to select all text when window is reopened, you can use Select Last Query. And you do not want to do that, you can use Preserve Last Query.

Closed.

Copy link
Author

1208nn commented Jun 6, 2025
edited
Loading

Oh, sorry.

I think I didn't make it clear.

for example (see #2945)

bm github

Select github

@Jack251970

Copy link
Member

Hmm, you mean just select part of query text

Copy link
Member

Why do we need that?

Copy link

github-actions bot commented Jun 6, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 24
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link
Contributor

Isn't this something that can be done with a custom query hotkey? It seems pointless to create it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /