-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add option_asset! to match asset! #4791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
+77
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user of the jujutsu VCS, manganis's
asset!plays a little awkwardly with/assets/tailwind.css.Since
tailwind.cssis generated and shouldn't really be checked in, it needs to be ignored from our Git repo. That said... theasset!macro statically fails to compile if the file is missing, socargo checkin a monorepo with a Dioxus workspace fails on a fresh checkout, untildxhas been used to build that repo at least once.With Git, an option is to put an empty
tailwind.cssthere and use--assume-unchanged(although that's ultimately local), but... jujutsu doesn't have this, and it'd be preferable if manganis could instead be encouraged to not fail hard when the file is missing.