-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Feature] Sso Backend support #3366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@github-actions
github-actions
bot
requested review from
Zzm0809,
aiwenmo,
gaoyan1998 and
zackyoungh
April 9, 2024 08:49
@Zzm0809
Zzm0809
changed the title
(削除) Sso Backend support (削除ここまで)
(追記) [Feature] Sso Backend support (追記ここまで)
Apr 9, 2024
Zzm0809
Zzm0809
reviewed
Apr 9, 2024
url: jdbc:mysql://${MYSQL_ADDR:127.0.0.1:3306}/${MYSQL_DATABASE:dinky}?useUnicode=true&characterEncoding=UTF-8&autoReconnect=true&useSSL=false&zeroDateTimeBehavior=convertToNull&serverTimezone=Asia/Shanghai&allowPublicKeyRetrieval=true
username: ${MYSQL_USERNAME:dinky}
password: ${MYSQL_PASSWORD:dinky}
url: jdbc:mysql://${MYSQL_ADDR:127.0.0.1:3306}/${MYSQL_DATABASE:dinky2}?useUnicode=true&characterEncoding=UTF-8&autoReconnect=true&useSSL=false&zeroDateTimeBehavior=convertToNull&serverTimezone=Asia/Shanghai&allowPublicKeyRetrieval=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rollback this file
...and get it from the configuration instead
Zzm0809
Zzm0809
reviewed
Apr 16, 2024
dinky-admin/src/main/java/org/dinky/controller/SsoCpntroller.java
Outdated
Show resolved
Hide resolved
Zzm0809
Zzm0809
reviewed
Apr 16, 2024
# If you use the h2 database, please configure the h2 database connection information in application-h2.yml,
# note: the h2 database is only for experience use, and the related data that has been created cannot be migrated, please use it with caution
active: ${DB_ACTIVE:h2} #[h2,mysql,pgsql]
active: ${DB_ACTIVE:mysql} #[h2,mysql,pgsql]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rollback this line
Zzm0809
Zzm0809
reviewed
Apr 16, 2024
Zzm0809
Zzm0809
reviewed
Apr 16, 2024
... interfaces after logging out.
Zzm0809
Zzm0809
reviewed
May 7, 2024
# Conflicts: # dinky-common/src/main/java/org/dinky/data/enums/Status.java
controller 逻辑下沉到 service 层, 配置封装一下配置类,而不是通过@value 获取
@yangzehan 需要写一下文档 集成步骤
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate github's oauth authentication.Other SSO authentication can be expanded in the future.
image
Users need to enable the sso function in the configuration
image
and configure the correct authentication parameters
Access the /sso/token port to log in.
image