Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Override AbstractJdbcDriver method getTable The default method takes ... #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yangzehan wants to merge 6 commits into DataLinkDC:dev
base: dev
Choose a base branch
Loading
from yangzehan:ove_gettable

Conversation

Copy link
Contributor

@yangzehan yangzehan commented Feb 6, 2024

image

image
原方法需要获取数据库中全部表的元数据再过滤比较花费时间

github-actions[bot] reacted with thumbs up emoji github-actions[bot] reacted with rocket emoji
import static org.dinky.utils.SplitUtil.contains;
import static org.dinky.utils.SplitUtil.getReValue;
import static org.dinky.utils.SplitUtil.isSplit;
import static org.dinky.utils.SplitUtil.*;
Copy link
Contributor

@Zzm0809 Zzm0809 Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处无需修改

Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider the situation where the data source does not support jdbc.

Copy link
Contributor Author

Please consider the situation where the data source does not support jdbc.请考虑数据源不支持 jdbc 的情况。

Now all drivers inherit AbstractJdbcDriver. if jdbc is not supported, the method can be overridden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zzm0809 Zzm0809 Zzm0809 left review comments

@aiwenmo aiwenmo aiwenmo requested changes

@gaoyan1998 gaoyan1998 Awaiting requested review from gaoyan1998

@zackyoungh zackyoungh Awaiting requested review from zackyoungh

Requested changes must be addressed to merge this pull request.

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /