-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Feature-1620][admin] Integrate Casdoor for SSO #2250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add casdoor login support SSO This closes DataLinkDC#1620
@aiwenmo Excuse me, what is this question
@aiwenmo Excuse me, what is this question
this is github action's problem, wait for a moment, fixing it.
@aiwenmo Excuse me, what is this question
hi, @gaopeng666 ,thank you very much for your pr, please add postgre's ddl/dml and h2's ddl/dml
@aiwenmo Excuse me, what is this question
hi, @gaopeng666 ,thank you very much for your pr, please add postgre's ddl/dml and h2's ddl/dml
Then please provide the design of the front-end page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better to remove Casdoor ? eg : The default tenant does not exist
Or use an existing USER_NOT_BINDING_TENANT instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that SSO login is a standalone login method and not a replacement for existing local logins?
@li7hai26
li7hai26
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Login type Casdoor is special, I think oidc (oauth2) is better than casdoor,=.=
@aiwenmo Excuse me, what is this question
hi, @gaopeng666 ,thank you very much for your pr, please add postgre's ddl/dml and h2's ddl/dml
Then please provide the design of the front-end page
ok, i will add
This closes #1620
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: