Exclude RDS objects and rdsadmin DB from sp_Blitz checks #3713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

yoni-yad2 wants to merge 1 commit into BrentOzarULTD:dev

from yoni-yad2:exclude-rds-objects-from-checks

Open

Exclude RDS objects and rdsadmin DB from sp_Blitz checks #3713

yoni-yad2 wants to merge 1 commit into BrentOzarULTD:dev from yoni-yad2:exclude-rds-objects-from-checks

+62 −27

Conversation

yoni-yad2

Copy link

@yoni-yad2 yoni-yad2 commented Sep 29, 2025

#3712

@yoni-yad2


 Exclude checks for RDS objects and rdsadmin DB

864d05a

See:
BrentOzarULTD#3712

BrentOzar

BrentOzar requested changes

Oct 18, 2025

View reviewed changes

Copy link

Member

@BrentOzar BrentOzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the pull request, but it looks like maybe some unrelated changes snuck in? Or can you explain these other changes, not sure why they were made? Sorry about the delay.

sp_Blitz.sql

IF @Debug IN (1, 2) RAISERROR('Running CheckId [%d].', 0, 1, 99) WITH NOWAIT;

EXEC dbo.sp_MSforeachdb 'USE [?]; SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED; IF EXISTS (SELECT * FROM sys.tables WITH (NOLOCK) WHERE name = ''sysmergepublications'' ) IF EXISTS ( SELECT * FROM sysmergepublications WITH (NOLOCK) WHERE retention = 0) INSERT INTO #BlitzResults (CheckID, DatabaseName, Priority, FindingsGroup, Finding, URL, Details) SELECT DISTINCT 99, DB_NAME(), 110, ''Performance'', ''Infinite merge replication metadata retention period'', ''https://www.brentozar.com/go/merge'', (''The ['' + DB_NAME() + ''] database has merge replication metadata retention period set to infinite - this can be the case of significant performance issues.'')';

EXEC dbo.sp_MSforeachdb 'USE [?];

Copy link

Member

@BrentOzar BrentOzar Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we change this section?

sp_Blitz.sql

GROUP BY LEFT(physical_name, 1)

HAVING COUNT(*) > 1

AND SUM(size) < 268435456 OPTION (RECOMPILE);';

HAVING COUNT(*) > 1 AND SUM(size) < 268435456

Copy link

Member

@BrentOzar BrentOzar Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we change this section?

Labels

None yet

2 participants

@yoni-yad2 @BrentOzar

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Exclude RDS objects and rdsadmin DB from sp_Blitz checks #3713

Are you sure you want to change the base?

Exclude RDS objects and rdsadmin DB from sp_Blitz checks #3713

Conversation

@yoni-yad2 yoni-yad2 commented Sep 29, 2025

Uh oh!

@BrentOzar BrentOzar left a comment

Choose a reason for hiding this comment

Uh oh!

@BrentOzar BrentOzar Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

@BrentOzar BrentOzar Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants