-
Notifications
You must be signed in to change notification settings - Fork 179
fix: Resolve race condition in AbortController handling during tab visibility changes #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yushihang
wants to merge
2
commits into
Azure:main
from
yushihang:fix/abort-controller-race-condition
Open
fix: Resolve race condition in AbortController handling during tab visibility changes #94
yushihang
wants to merge
2
commits into
Azure:main
from
yushihang:fix/abort-controller-race-condition
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeline of the race condition: Time 0: - AbortController instance A is created - Request A is initiated with instance A Time 1: (User switches tab, making it invisible) - onVisibilityChange() is triggered - abort() is called on instance A - create() is queued to execute when tab becomes visible Time 2: (User switches back, making tab visible) - create() executes - AbortController instance B is created - Request B is initiated with instance B Time 3: - Request A's abort error is caught in catch block - Bug: Code checks instance B's abort status instead of instance A's - Since instance B is not aborted, onerror callback is wrongly triggered - This leads to an unnecessary retry attempt Fix: Store AbortController instance in local scope to ensure error handling uses the correct instance: Before: ```ts curRequestController = new AbortController(); // Later in catch block if (!curRequestController.signal.aborted) ``` After: ```ts const currentController = new AbortController(); curRequestController = currentController; // Later in catch block if (!currentController.signal.aborted) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Issue
close #95
A race condition exists in the error handling of aborted requests when rapidly switching browser tabs. This causes unnecessary request retries and incorrect error handling behavior.
Current Behavior
When switching browser tabs quickly:
Root Cause
The issue stems from using a shared global
curRequestController
variable across different async contexts. When error handling occurs asynchronously, it may check the abort status of a different controller instance than the one that initiated the request.Solution
Store the AbortController instance in the function scope to ensure each request's error handling uses its own controller:
Impact
Testing
Verified by: