Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

globalThis instead of window #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oudmane wants to merge 1 commit into Azure:main
base: main
Choose a base branch
Loading
from oudmane:globalThis
Open

Conversation

Copy link

@oudmane oudmane commented May 6, 2023

This make is possible to use this package on a browser extension or NodeJS

piotr-cz, kevin-dp, and codemile reacted with thumbs up emoji
Copy link

Hey mate, thanks for writing this. Noticed this one's been sitting here for a while.

Would you happen to have your own NPM fork published of it?

(I did a quick search, but couldn't find anything resembling your username here on NPM)

kevin-dp added a commit to electric-sql/electric that referenced this pull request Jun 9, 2025
This is a follow up PR on
#2546 and
#2544. It solves a bug
related with 409s (must refetch) in SSE mode and it replaces the
EventSource browser API by the
[fetch-event-source](https://github.com/Azure/fetch-event-source)
library. I refactored the `ShapeStream.#start` method which was becoming
very big and complex. To this end, i split the logic into helper methods
that handle the different parts that need to happen (building the shape
URL, making the request, parsing the response headers, handling the
response body, etc.).
I had to patch the
[fetch-event-source](https://github.com/Azure/fetch-event-source)
library because it relies on browser-specific features such as
`document` and `window` (cf.
Azure/fetch-event-source#41). But we want our
client to also work in server-side JS environments.
I also had to patch the `fetch-event-source` library because it does not
abort the fetch when you pass an already aborted signal. A complete
description of the bug and the fix can be found here:
Azure/fetch-event-source#98.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /