-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix: Handle OSError when git config lock fails on network drives #4576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SANJAY23CB50
wants to merge
2
commits into
Aider-AI:main
from
SANJAY23CB50:fix-network-drive-lock-issue
Open
Fix: Handle OSError when git config lock fails on network drives #4576
SANJAY23CB50
wants to merge
2
commits into
Aider-AI:main
from
SANJAY23CB50:fix-network-drive-lock-issue
+82
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ap config_writer() in try-except block - Add graceful error handling for permission issues - Prevents crash when using repositories on network drives - Fixes Aider-AI#4508
CLA assistant check
All committers have signed the CLA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using aider on network drives or with certain file system configurations, the
repo.config_writer()call can fail with anOSErrordue to file locking issues. This causes aider to crash during the git setup phase.Solution
config_writer()call in a try-except block to catchOSErrorandPermissionErrorTesting
tests/basic/test_git_config_network.pywith test coverage for the error scenarioFixes #4508