openstack/nova - nova - OpenDev: Free Software Needs Free Tools

Updates the rxtx_factor validations in the instance_types modules so
that rxtx_factor is validated as a float. Given that rxtx_factor is stored
as a float in the database this makes sense... and also adheres
to some of the extension documentation as well (although some of
the extension docs were incorrect as well).
Previously rxtx_factor was being cast into an int which caused it to
be stored and displayed incorrectly via the API.
This patchset adds a test which fails with the old code.
Additionally some of the API docs are corrected so that rxtx_factor is
listed as a float in all examples.
Fixes LP Bug #1081287.
Change-Id: Iae98522a1f2ed63cbd2497b0b0af5ac2d9bb935c

The cast_to_volume_host() and cast_to_host() methods have not been
used since compute RPC API is introduced. This patch removes these
methods and the coresponding tests as well.
Change-Id: Icd2b4b2245cc7662c8dcb6fd35d6c33b77d0429b

Change-Id: I724ac38f1f98b27ed30382dc5f8c1789d0cc42f9

Without this file in place I was seeing some test failures from the
baremetal unit tests. The failure was:
 ImportError: No module named baremetal.db
Change-Id: I7596e7916796d5cb382d3856918b35c01814a455

This patch adds a migration_update method to the conductor API. This is
used by the compute manager to push off db access to nova-conductor.
The only field that compute was updating was the status, so that is the
only field allowed by the API.
Instead of just sending the miration_id to the conductor, we are sending
all of the migration data. This is done in the spirit of
'no-db-messaging'. While no other data is needed right now, it's easier
to send it all now than have to change the API later.
Change-Id: Ic3150fbc6d5e7b0c9e41681950a7424129cbc968

The instance_update method was setting the topic to self.call(), but the
value being passed is the default, so it's unnecessary. Just remove it.
Change-Id: Iaabd246b8528a0858ee239e790bfcb13e919399a

Summary:
* provide a pluggable ServiceGroup monitoring API
* refactor the old DB-based implementation to the new API
Currently nova compute nodes periodically write to the database (every
10 seconds by default) to report their liveness. This implementation
factors out this functionality and make it a set of abstract internal
APIs with a pluggable backend implementation. Currently it's named as
ServiceGroup APIs.
With this effort, we are hopeful to see the following benefits:
 * We expect to see more backend implementations in addition to the
default database-based one, such as ZooKeeper (as described in
blueprint zk-service-heartbeat) or rabbitmq heartbeat based.
 * We expect the code to live in openstack-common so projects other
than Nova can take advantage of the internal APIs.
 * Lay the foundations to use lower overhead heartbeat mechanisms
which scale better.
 * Other than reporting whether a node in a service group is up or
down, the code may also be used to query for members. Other parts of
the code could also take advantage of the new APIs. One noteable
example is the MatchMaker in the rpc library, which may even become
redundant. We have been working with Eric at Cloudscaling to see how
this fits with the matchmaker. It is likely that this code will need
to be used, at least by the peer-to-peer based RPC mechanisms, to
implement the new create_worker method.
DocImpact: new config options
Co-authored-by: Pavel Kravchenco <kpavel@il.ibm.com>
Co-authored-by: Alexey Roytman <roytman@il.ibm.com>
Change-Id: I51645687249c75e7776a684f19529a1e78f33a41

Since glance now supports SSL, we need to take
this into consideration when generating the URL.
Also updates and adds a test.
A new config option 'glance_protocol' was added
that defaults to 'http' since that's what the
glance options, '*_client_protocol', default to.
Set to 'https' for SSL.
Change-Id: Id231a1fd4c4d8e221ae0cf6541181e5572dff02b

This adds the use of eventlet's db_pool module so that we can make mysql
calls without blocking the whole process.
New config options are introduced:
sql_dbpool_enable -- Enables the use of eventlet's db_pool
sql_min_pool_size -- Set the minimum number of SQL connections
The default for sql_dbpool_enable is False for now, so there is
no forced behavior changes for those using mysql. sql_min_pool_size
is defaulted to 1 to match behavior if not using db_pool.
Adds a new test module for our sqlalchemy code, testing this new option
as much as is possible without requiring mysql server to be running.
DocImpact
Change-Id: I99833f447df05c1beba5a3925b201dfccca72cae

Several tests require changes to ensure that the conductor service
is started (or set to local mode) before they ask the compute
manager to do instance updates.
Changes were required to some of the tests that check the value
of the timestamps by converting to strings. After passing the instances
through jsonutils.to_primitive(), the strings are a bit different.
Change-Id: I660e471178f3e5b36c4be27d47047fb4e4e1f851

* Addresses bug 1073212
Change-Id: I50327a9d7051d9ddb0a95a89b50037873011aff4

nova-dhcpbridge's FLAGFILE environment variable is one of the few
remaining references we have to "flags".
Switching to use a new environment variable is easy, but we need
to take care that when you upgrade the code the compute and network
services might not be restarted immediately.
If this happens, the services may launch a new dnsmasq (so rootwrap
needs to continue to support FLAGFILE) or an existing dnsmasq might run
the lease script (so the script needs to support FLAGFILE).
Change-Id: Ieb55daa2507abb8327c7f5a2ef2f682740f31a5d

Rename (via drop and recreate) the instance_uuid unique
constraints on the instance_info_cache table so they reflect
the column change name (UUID conversion) we complete in Folsom.
Fixes LP Bug #1080837.
Change-Id: I9dd01ebc896c1d7b51c212980e48db16bad18dec

Move assignment of the node field on the instance to the compute host
to be more consistent with how the host field is assigned and handled
by the resource tracker.
Change-Id: Id3086585a99350abbab387932e689825b33ab6b5

Change-Id: Icd341b1351fa0755f0fede48ae1aa26c37b2c31c

errno is no longer used since folsom-2-1095-ge88218e
Change-Id: I28702b3cd5e98b42172a45592954b9ba98bb5972

Fix for lp:1057279.
Change-Id: I9da0fd42e919aca0075613c4930ebfc3cf425349

We always launch dnsmasq with FLAGFILE set, so something is very broken
if FLAGFILE isn't set when nova-dhcpbridge is launched.
Also, the fallback to CONF.dhcpbridge_flagfile is a little strange - at
this point, we haven't parsed any config files so the only possible
value of this config option is its default value.
There's no real need to gracefully handle this condition either - a
KeyError is a straightforward enough error.
Change-Id: I734d7b739f17c8a9ab48d8ba13baacff3f00e1c4

It fixes bug 1082275
The current version of the HyperV Compute driver wasn't returning
CPU information when it reported its resources.
In order to solve it, this patch extracts the cpu properties
from WMI and Win32 calls.
Change-Id: I5c2a89b5e432f4e958354a15582258d4cff83658

The tests in test_flags don't test any Nova specific code. At this point
they just test a fairly random set of cfg use cases that are already
covered by cfg's unit tests.
Change-Id: I752d9676824eb479fcaef2c89a0a42fcfab45f8c

Resolves bug 1081436 where they were returning a 5.5gb console log
to the user.
Change-Id: I0d98c83e801f8936d35789b5e8f8283f49483c4e

There are global fixtures that get set up for testing in
nova/tests/__init__.py, even though there is a base test class. As we move
towards parallel testing, we want to convert all of these into proper fixtures.
As a step towards that, move them into nova/test.py so that it's clear that
they are part of the global test setup. From there we'll move them into
proper fixture classes.
Part of blueprint grizzly-testtools
Change-Id: Ia0b0ae380069a212bc20e009d1088c2bad7d9177

Both Ubuntu and Debian place the hvmloader in a
different path which depends on the version is installed.
The reason why this done is so you can different versions
of Xen installed.
As a result change the hvmloader to a configurable option
for libvirt called xen_hvmloader_path.
Change-Id: Ic407d14f56a2518de4cd4ab8872ac2055d20adcd
Signed-off-by: Chuck Short <chuck.short@canonical.com>

During the instance creation a dictionary of instance characteristics
(base_options) is created in nova.compute.api._create_instance where
"architecture" is defined looking into image[properties].
Then "architecture" entry is updated to the same value in
nova.compute.api._populate_instance_for_create if defined or it removes
the 'Unknown' value for this key.
This patch removes the unnecessary "architecture" update.
Change-Id: Id76dedef8fc96dcd6fa5b72ace6c50c85e04215b