don't allow volumes to be attached to the same mountpoint

openstack/nova

Code Issues Proposed changes

This commit is contained in:

Vishvananda Ishaya

2010年06月24日 04:11:57 +01:00

committed by andy

parent 9d5f9e12e2

commit 9ebd49fa09

1 changed files with 5 additions and 1 deletions

@@ -320,7 +320,11 @@ class CloudController(object):

def attach_volume(self, context, volume_id, instance_id, device, **kwargs):

volume = self._get_volume(context, volume_id)

if volume['status'] == "attached":

raise exception.Error("Volume is already attached")

raise exception.ApiError("Volume is already attached")

# TODO(vish): looping through all volumes is slow. We should probably maintain an index

for vol in self.volumes:

if vol['instance_id'] == instance_id and vol['mountpoint'] == device:

raise exception.ApiError("Volume %s is already attachted to %s" % (vol.volume_id, vol['mountpoint']))

volume.start_attach(instance_id, device)

instance = self._get_instance(context, instance_id)

compute_node = instance['node_name']