openstack/networking-bgpvpn - networking-bgpvpn - OpenDev: Free Software Needs Free Tools

Add file to the reno documentation build to show release notes for
stable/wallaby.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/wallaby.
Sem-Ver: feature
Change-Id: I8768634717b3b8e4a9ed5af1b684986b0e04fed0

UPPER_CONSTRAINTS_FILE is old name and deprecated
This allows to use upper-constraints file as more
readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>.
Change-Id: I0c8c2c4a783c4f0ac9f7530d4d18937ce5b17c61

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I4d015cfe8b97e0fc1259d47c89f4b0704accb61c

l-c job recently failed too much, and maintaining it is huge job.
As on stable branches we decided (see [1]) to drop l-c testing, meke
non-voting it for networking-bgpvpn in check queue, and remove from
gate queue.
[1]http://eavesdrop.openstack.org/meetings/networking/2021/networking.2021年01月12日-14.00.log.html
Change-Id: Ib5628cf79ab8bc099fb5f8b00f5302a34fa26655

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I4045c12d022b06a26f7e5e1765b3fb9834c1058b

Jobs "networking-bgpvpn-bagpipe-dsvm-install" and
"networking-bgpvpn-dsvm-install" was renamed recently as part of zuulv3
migration to networking-bgpvpn-bagpipe-install and to
networking-bgpvpn-install
Change-Id: If9b5ce8522acf298c037b14fa11dc5b97f8c8bef

in 'victoria' cycle, we should test py38 by default.
[1] https://governance.openstack.org/tc/reference/runtimes/victoria.html
Change-Id: I023720594810d346649fcda24ce011ce15955fc6

hacking 3.0.1 fix the pinning of flake8 to avoid bringing in a new
version with new checks.
bumping the min version for hacking so that any older hacking versions
which auto adopt the new checks are not used.
Change-Id: I4aca49327fb8fb0f03b7c262f8247186245cbc19

This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for wallaby.
See also the PTI in governance [1].
[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html
Change-Id: Iff34c4159a831f3ccbb459fb4dd4767c3b0c1e1a

Add file to the reno documentation build to show release notes for
stable/victoria.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/victoria.
Change-Id: I0761cdf1501b9bb19fb81e50d0080b70495a6b67
Sem-Ver: feature

This patch is a clean-up patch for refactor-error-messages bp
which remove the exception message from base message otherwise
the same exception message display twice like
this https://ibb.co/XyFWMdz .
Depends-On: https://review.opendev.org/#/c/708069/
Change-Id: Ic7061cd293b238c497f0f4343aa3cc0e7996d5a0

As the 'all-plugin' tox env is deprecated it is recommended to use
'all' tox env instead.
[1] https://review.opendev.org/#/c/543974/
Change-Id: I827fa6d9a077efd0d3b5792fee6145dc604d371a
Related-Bug: 1862240

As per victoria cycle testing runtime and community goal[1]
we need to migrate upstream CI/CD to Ubuntu Focal(20.04).
Bump the lower constraints for required deps which added
python3.8 support in their later version.
Story: #2007865
Task: #40199
[1] https://governance.openstack.org/tc/goals/selected/victoria/migrate-ci-cd-jobs-to-ubuntu-focal
Change-Id: Ie96f1049ea053200f3087eee81351848318727b2

networking-bgpvpn-bagpipe-dsvm-install and
networking-bgpvpn-dsvm-install jobs are still legacy jobs, this patch
aims to move them to zuulv3 syntax. The new job names are:
networking-bgpvpn-bagpipe-install and networking-bgpvpn-install
Change-Id: I75e66d864f175fef19b0f20155dec60725496034

Make the code compatible with hacking rules:
* import order problems
* line break before/after binary operator (for this added ignore for
W504, line break after binary operator
* indentation problems
I removed the rule N530 (Direct neutron imports not allowed), as that is
a longer story.
As a side-effect use newer pylint version, and fix the problems reported
Change-Id: I701c89ecc890a1d866815b5401cd4c022c51c9c4
Depends-On: https://review.opendev.org/#/c/708965/ 

New versions of isort broke pylint. This patch fixes it at 4.3.21.
Make sure that siblings are installed for functional tests.
Change-Id: Id04da60731543d970de6a1a88da5a32435be1aae

The __future__ module [1] was used in this context to ensure compatibility
between python 2 and python 3.
We previously dropped the support of python 2.7 [2] and now we only support
python 3 so we don't need to continue to use this module and the imports
listed below.
Imports commonly used and their related PEPs:
- `division` is related to PEP 238 [3]
- `print_function` is related to PEP 3105 [4]
- `unicode_literals` is related to PEP 3112 [5]
- `with_statement` is related to PEP 343 [6]
- `absolute_import` is related to PEP 328 [7]
[1] https://docs.python.org/3/library/__future__.html
[2] https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html
[3] https://www.python.org/dev/peps/pep-0238
[4] https://www.python.org/dev/peps/pep-3105
[5] https://www.python.org/dev/peps/pep-3112
[6] https://www.python.org/dev/peps/pep-0343
[7] https://www.python.org/dev/peps/pep-0328
Change-Id: Ic7fd095674f1e2717d686c1e4a69bad60146c9f3

_MovedItems is defined in six, six has been removed,
so it can also be removed.
Change-Id: I837db304696c1eb9d3580a64290e6148247aa0bd

With python3.x, classes can use 'metaclass=' instead of
'six.add_metaclass'.
Change-Id: I69814806752e7dab67f643c424e75462fbc6a033

Switch to openstackdocstheme 2.2.1 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering problems
Update Sphinx version as well.
Set openstackdocs_pdf_link to link to PDF file. Note that
the link to the published document only works on docs.openstack.org
where the PDF file is placed in the top-level html directory. The
site-preview places the PDF in a pdf directory.
Disable openstackdocs_auto_name to use 'project' variable as name.
Change pygments_style to 'native' since old theme version always used
'native' and the theme now respects the setting and using 'sphinx' can
lead to some strange rendering.
openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.
See also
http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html
Change-Id: I8cef6410228b4824afe974a5ab4279ef1bd35883

Now that we no longer support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.
Change-Id: I2cf3afe0ce833e5d85563a6b10f9ac71f3b8c485
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

By change we noticed that networking-bgpvpn unit and functional
tests were failing in CI in a case where master version of
networking-bagpipe wasn't mistakenly not used.
While that minor mistake was fixed by configuring zuul.yml
to always set networking-bagpipe in required-projects, we still
would prefer test-requirements.txt to specify a version that
can allow to execute tests, even out of zuul CI and tox-siblings
jobs.
This change updates the minimum version of networking-bagpipe
to the lowest possible version that consumes objects.common_types
from neutron-lib instead of neutron.
Change-Id: Ib3fe3c8248cff5d8ef154fc52d6e20f66108961f

This repo is now testing only with Python 3, so let's make
a few cleanups:
- Remove python 2.7 stanza from setup.py
- Remove obsolete sections from setup.cfg
- Update classifiers
- Update requirements, no need for python_version anymore
- Use newer openstackdocstheme and Sphinx versions
- Cleanup */source/conf.py to remove now obsolete content.
- Add pytest as test-requirement, horizon needs this now
 for calling horizon tests
- Add mock as test-requirement, this repo needs mock and
 did not declare it.
Change-Id: I402053fb4e41d91d19005f2c1c070af2918d0ceb

This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for victoria.
See also the PTI in governance [1].
Manual change:
- add py38 with required-projects to gate so that this works in both
 check and gate
[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html
Change-Id: I653f3d863bcdbeac6874a6e51e1e86ea16a18c78

Remove unnecessary things from tox.ini:
- install_command: it's better to use the built-in install command
- VIRTUAL_ENV: this is set anyways
- sitepackages: it's enough to use virtualenv's packages
Besides these seem to be unnecessary 'sitepackages' setting started to
break functional job with an error message that there are missing
packages, however those were installed. By removing sitepackages=True
setting the errors dissapear.
Closes-Bug: #1876028
Change-Id: Ifc4904fa89eb7fcaaa8cd623112f419ac57ea286

In some environments unit tests fails due to tests attempting to
access /etc/neutron/ and not having permission to do so. Let's
mock out add_provider_configuration to avoid this behaviour in
unit test environment.
Change-Id: If385c26e4a6bd9eca5bd873df4d25a2d888dd9a9
Closes-Bug: #1872514 

Add file to the reno documentation build to show release notes for
stable/ussuri.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/ussuri.
Change-Id: I32c819a7129763f4afc509d879f7b0fa85d75705
Sem-Ver: feature

* pep8 execution failed on pylint phase with some astroid traceback for
 RuntimeError: generator raised StopIteration.
 The issue can be solved by setting both pylint and astroid versions.
 The new pylint causes some new checks, like inheriting from object which
 in py3 is not necessary again to write out.
* Fix some db shcema mismatches between migration scripts and model.
* Bump the lower bound of pyScss which is a dependency of horizon
 to 1.3.7 to make it work with setuptools 46. This just follows
 horizon change https://review.opendev.org/#/c/715241/.
Change-Id: I4119f6455e7af83cf397dec531b0a11f88112f21

This is a follow-up for https://review.opendev.org/#/c/604335/.
The dependency change is worth having a release note.
Babel is also dropped from requirements.txt.
It is a horizon dependency and there is no need to have it here.
Change-Id: Ic050602958270935e8dd1b67f4cc0ff4d0df6134

Horizon is not a key dependency for networking-bgpvpn and right now it
forces projects to install horizon if they want to use networking-bgpvpn
which does not make sense.
"extras" allows us to declare optional dependencies [1].
networking-bagpipe is an optional dependency and
it is specified as extras too.
[1] https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras
Change-Id: I0e15124db206dafde51166e33e3284e86252d936
Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Signed-off-by: Manuel Buil <mbuil@suse.com>

This patch switches from legacy jobs to standard jobs
(neutron-functional for functional jobs)
Clean up relevant files from legacy jobs
Remove hook calls in install jobs as they did nothing
TODO: not sure what to do about the install jobs, should we keep them?
Change-Id: If27b989195999d202fb819b01fe085c143b920f4

unittest2 was needed for python<=2.6, it is time to remove it from
requirements.
Change-Id: Ib37113966075ec802a1d729d96dfd32da1ade370

Fix lower constraints for tests work again.
* neutron, networking-bagpipe, networking-sfc and networking-odl
 are removed from lower-constraints.txt. They are installed
 from a same branch and are released per cycle, so including them
 in lower-constraints does not make sense until a beta release is
 cut during a development cycle.
* horizon requirement is updated to match the Ussuri deliverable.
 horizon switched the release model to cycle-with-intermediary in Ussuri
 so we can specify horizon version in lower-constraints.txt.
Updated entries are identified and verified in the following steps:
* Check ERROR line in .tox/lower-constraints/log/lower-constraints-1.log
* Check all modules are installed baesd on lower-constraints-1.log
 and no '>=x.y.z' requirements appears.
* After creating 'lower-constraints' tox venv, neutron,
 networking-bagpipe, networking-sfc and networking-odl are installed
 manually using .tox/lower-constraints/bin/pip and check no additional
 modules are installed. If some modules are installed, it means they
 should be covered by lower-constraints.txt.
Signed-off-by: Thomas Morin <thomas.morin@orange.com>
Submitted on behalf of a third-party: Orange
Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: Ie079c93cb752b6aef9b0505a0492719993729621

Fix sphinx requirements for python 3 so that tests work again.
Change-Id: I581b48d9ff6a8c05556faa57e45ad17569d65cea

Django 1.11 ends its extended support in April 2020 (which is before
Ussuri release), so horizon drops Django 1.11 support in Ussuri.
tox envs for non-primary Django versions are no longer needed in tox.ini
as testing environments for non-primary Django versions are setup in
the zuul jobs now.
horizon>=17.1.0 is required to use Django 2.2. requirements.txt and
lower-constraints.txt are updated accordingly. for more info. please
refer [1].
Depends-On: https://review.opendev.org/#/c/700733/
[1] https://etherpad.openstack.org/p/Enable_Django22_support_in_Horizon_Plugin
Change-Id: Icdd22683361a56a366af5d8d5c9b082e98abbe21

babel extractors are now registered via python entry points,
so there is no need to declare babel extractors in babel configs.
This change is important to make translation work in Django 2.2.
django-babel does not work with Django 2.2 and looks unmaintained
for over two years. The horizon team is thinking to switch the extractor
to enmerkar (a fork of django-babel) to make extraction of translation
string work again near future. It is important to drop the extractor
definition to make the transition smooth.
Change-Id: I997dc7d2f572a9be627f7aa5d463f20ee23895ff

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I49c675d4a8bfcba05757d9e052bddde881f0beea