openstack/networking-bgpvpn - networking-bgpvpn - OpenDev: Free Software Needs Free Tools

With this change we now import validate_regex from neutron_lib.
Additionally, we remove useless code (the plurals in our API are
not special).
Change-Id: I5bdf8b66274d5808c9e49e0e03da3c1e88f76e0a

Releasenote translation publishing is being prepared. 'locale_dirs'
needs to be defined in conf.py to generate translated version of the
release notes.
Note that this repository might not get translated release notes - or
no translations at all - but we add the entry here nevertheless to
prepare for it.
Change-Id: I5d133b10ae729e0ff59faf2722f0a9a46272033c

This is required because the place where plugin_agent_add_l2_agent_extension
is defined is not sourced by default.
Change-Id: Ib1de7cfec457a312319edddd5262cd78c6599f0b

Now that ML2-generated Port AFTER_UPDATE registry notifications have
complete port information, we can use the AFTER_DELETE callbacks, which is
the right moment to react on Port deletion.
Change-Id: I84fb6fc63de03ffcba9c1d0ef2772d31429a6031
Partial-Bug: 1576440

ML2 code has for some time now been updated to provide both port and
original port information in Port AFTER_UPDATE notifications, in all
code paths.
We can thus simplify bagpipe driver and remove now-useless workarounds.
Change-Id: Ic46234261988ef8ec696e4788f1350e7a6608239
Partial-Bug: 1576440

As mentioned in the spec, a router and one of its subnet
cannot be both attached to a bgpvpn.
This patch enforce this rule by adding a check when a subnet is
attached to a router.
Co-Authored-By: Wim De Clercq <wim.de_clercq@nuagenetworks.net>
Change-Id: Ie1f6a733e8a16b8b41e89c5a82637d7cb03bd423
Closes-bug: #1537067 

remove redundant 'in'
Change-Id: I18d07f596ddb8e3a30e42431e8cc9a360307f26d

This change removes Python 3 as a listed language under the
classifiers section in setup.cfg, to prevent packaging systems
from incorrectly reading python 3 support
Change-Id: I63b816db36f102b69049cca5096c5fb4cdf60454

(has moved from neutron.db to neutron_lib.db)
Change-Id: I0408e25edec3c851696aa48474ff4a3eb9fda6c6

This commit switches the use of plain testr for os-testr in the tox
venvs.
Change-Id: I285f820b7de3109665dd7a38da389b7fd42acf80

This patch removes logging import unused in
bgpvpn_dashboard/dashboards/admin/bgpvpn/forms.py
bgpvpn_dashboard/dashboards/project/bgpvpn/tables.py
networking_bgpvpn_tempest/tests/base.py
Change-Id: I812cb0be14515faab7bf4132266b7011c0f90491

This change is needed to have the OVS agent extension for the bagpipe
driver enabled (because of [1]).
[1] https://github.com/openstack/neutron/blob/stable/newton/devstack/lib/l2_agent#L12
Change-Id: I1f4c86a6ae15985e581d0fd0a03754b2c5a5d571

Add a new panel BGPVPN in project section to display BGPVPN created
for non admin user.
The page allow actions as edit and update associations
networks or routers for BGPVPN resources.
Some part of code has been refactored to put in common methods or
classes between project and admin panels.
Change-Id: I49bfdfe1427c67f6b19a7b4faec0ab77a15ce8a5
Implements: blueprint horizon-tenant-workflow

How to configure the bgpvpn plugin for devstack is not
written in the doc.
Change-Id: I45082d20b83cf368901545a373f1c20368aeee13

Using the horizon UT framework will simplify our dashboard
test and avoid issue due to horizon future evolutions
Change-Id: I719a9912ba8e7fe87620850017bdda83431e22da

Our UTs related to resource creations test the result of the creation
API call. Neutron recently introduced the patch
I8775aa8a477191ef21e7c3c6da31d098befefc3c which automatically adds the
project_id and tenant_id to any create API call, and then breaks out UTs.
This patch relaxes our UTs by only testing that expected values are part
of the response to a resource creation API Call.
This patch fix another issue in the gate introduced by
I59cbd8bff117813258539ed0724fe89a9f5b77ee
Our horizon test framework needed an adaptation.
Change-Id: I320bcbf16ce9c30fca8821fe9e9202514bec1b6e

This fix enables BGP L2-type VPNs to be passed over to
OpenDaylight.
The upcoming Carbon release of OpenDaylight will start
supporting L2 BGPVPNs (Or Ethernet VPNs).
Change-Id: I8cc8659dc5ba5365ec4cf8872512201a496b5d4c
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>

Change-Id: I3dbd54364165b489871214b308a18c7b4a71f91d
Partial-Bug: #1607664 

* Improve the set of tests to be more exhaustive. The goal of these tests is
 to check that the reading restrictions between user of different tenants
 are preserved.
* The tests added are:
 * show bgpvpn object made by a non owner fail.
 * show network association made by a non owner fail.
 * list network associations made by a non owner fail.
* Add new methods to the BgpvpnClient (list, show).
* Rename some methods/calls to be more standard.
Change-Id: I7a3d773b30aa4ceaf13022f200f6fc6a49934ec2
Partial-Bug: #1607664 

NotImplementedError is the name of the exception
(https://docs.python.org/2/library/exceptions.html).
NotImplemented is the name of a constant
(https://docs.python.org/2/library/constants.html).
>>> raise NotImplemented()
Traceback (most recent call last):
 File "<pyshell#31>", line 1, in <module>
 raise NotImplemented()
TypeError: 'NotImplementedType' object is not callable
>>> raise NotImplementedError()
Traceback (most recent call last):
 File "<pyshell#32>", line 1, in <module>
 raise NotImplementedError()
NotImplementedError
 This patch fix it.
Change-Id: I5f38f34f59ffed87baa9269aa0f7b848bcacc8fa
Closes-Bug: #1339855 

Similarly as in I02b28d3b354c3b175147c5be36eea4dc7e05f2a3 .
Change-Id: Ia8fd880e6a4dda080befedc4a85a9fa7b55f7772

Not sure why pep8 didn't complain at merge time, but it is
complaining now in my setup.
Change-Id: I5fe65c47a4ace13e21741804730c5815b4e2b32d

(required to avoid a deprecation warning)
Change-Id: Ie611cbdc25fb1fcea67e16d11a45307a708cab92

Catch the exception raised by the UUID library in the case of a
malformed UUID and raise an OpenContrailMalformedUUID managed by
Neutron server logs.
Change-Id: I05dc8a380a3e5a8d54f21cef186cb532ec9461f2
Closes-Bug: #1604748 

* Configure the second openstack user by providing the "alt"
 client_manager.
* Add the test function which checks that a user cannot read
 bgpvpn resources that it does not own.
* Add some comments in the BgpvpnTest description.
Change-Id: Ia1edea9f414384a59b0568d0d733e3413944bd05
Partial-Bug: #1607664 

Test checks that invalid route targets are rejected by the create and update api.
Test checks that invalid network,bgpvpn id are rejected by the associate and disassociate api.
Change-Id: I181a1876f654ce5821c6bc212696d7be2801acde
Partial-Bug: 1607664

Change-Id: Ibd2f50797b4d6c6b34cda6bf3f219644af0ffe43
Partial-Bug: #1607664 

now that they haved moved out of neutron repo,
import api validators/converters from neutron_lib
Change-Id: I9f333f69533da5f4632e89aab5194f8ee5d216e5
Signed-off-by: Morgan Richomme <morgan.richomme@orange.com>

remove override of DEVSTACK_GATE_TEMPEST that is defined in jenkins job,
and run only bgpvpn's tempest tests using a regex filter.
Change-Id: Iae534db7bd34624fad135dad4f5b6f34fc5143bf

Since I1d633810bd16f1bec7bbca57522e9ad3f7745ea2 has merged we have a few
unit test failing because our Ports are not created with the same tenant_id as
the one specified in our 'context'.
This patch forces the use of the generic Neutron test tenant id everywhere.
Change-Id: I8c28c061ce091acf07d221b0b2bf0eb003f9e7d8

Change-Id: I984adf767ffaf60a43df1baa97a377b55f95eaf5
Signed-off-by: davidblaisonneau-orange <david.blaisonneau@orange.com>

Only in the opencontrail driver (as other neutron resource creation)
Improve the opecontrail_client by adding the 'project' resource
Add a function that check the tenant ID by reading (show) the project
Made the check in bgpvpn 'create' and 'update' functions
Change-Id: Iedea7863bed39d9a8f4bff1e2fa647bdd45ba3a5
Closes-Bug: #1604748 

Now that the tenant_id rename has merged in Neutron we can
remove the temporary work-around.
Also switch from the deprecated models_v2.HasId to the relocated
model_base.HasId
Related Blueprint: keystone-v3
Change-Id: I83c04e3455deade9ed1dda823d1a321579fba808

Many deprecations are triggered early (on imports, for example)
before the warnings are enabled by the WarningsFixture in the
base test class.
To make sure all DeprecationWarning messages are emitted we enable
them via the PYTHONWARNINGS environment variable.
Change-Id: Id88216090ea0ebdf9c1353eb713ccfed72c84630

Network assocation and disassociation client functions have also been
added.
Change-Id: I5494c3f7c85105bc22e508e09d2c32a09d664477
Partial-Bug: #1607664