openstack/networking-bgpvpn - networking-bgpvpn - OpenDev: Free Software Needs Free Tools

Change-Id: I457d3a8fd67c524885063ddebf0d9bf875419fd9

Depends-on: I48cf45dc1b07035d952152eac2548a3bd9fc2832
Change-Id: I9d3ef06130adc71fc3b269b33e3779ab9f4657b9

Introduce precommit hooks for all delete_bgpvpn_xxx
methods in the bgpvpn plugin.
The precommit hooks introduced here will be used by
ODL BGPVPN Version 2 driver to write to journal
on precommits.
Also subtransactions=True were missing for net_assoc and
router_assoc methods inside bgpvpn_db and has been added
as part of this fix.
Change-Id: I422cfb5ff5c2a15c4a80430ba99e19b9ae768b06
Closes-Bug: #1664637 

From Ocata release the new ODL BGPVPN Driver v2 is available and v1 diver
is being deprecated. Add a warning log message to inform users of v1
driver so they can switch to the new v2 driver.
Change-Id: Id58f0df0b0825ad78dff586a1bea07a78a19ec05
Partial-Bug: #1632117
Depends-On: I08485db8f10f15591d70474a4b8546990d4de166

This reverts commit 205452bfff.
As explain in that last version of the neutron client documentation [1]
(from review [2]) and to follow the OpenStack Client (OSC) and the
OpenStack Python SDK migration, Neutron stadium projects CLI extensions
should reside in the python-neutronclient project under the repository
'neutronclient/osc/v2/<extension>'
[1] http://docs-draft.openstack.org/71/407271/2/check/gate-python-neutronclient-docs-ubuntu-xenial/d30c3c8//doc/build/html/devref/transition_to_osc.html#developer-guide
[2] https://review.openstack.org/#/c/407271/
Change-Id: I099faee06bc3d4d634a96f45560a070f2a23bb56
Depends-On: Ib1ba356e994a98712e00a11ff045df67fbe4c7ea
Partial-Bug: #1650204 

Earlier, only one RD from the list of RDs for a BGPVPN was
passed to OpenDaylight since OpenDaylight Controller had
a limitation that it can process BGPVPNs with only a single RD.
From Carbon release cycle, OpenDaylight is being enhanced to
support BGPVPNs that host multiple RDs.
Change-Id: If9fbf447e1048d52ca749ca6757b45b729223e76
Closes-Bug: #1662930 

A motivation is that neutron does not complain
with a clear error message when networking_bgpvpn.conf
is not found.
Change-Id: I2688c6303fbcacb5a0e633cb309f2b5ae51ea1a6

The gating on python 3.4 is restricted to <= Mitaka. This is due to
the change from Ubuntu Trusty to Xenial, where only python3.5 is
available. There is no need to continue to keep these settings.
This patch add support python 3 to classifier and drop py34 environment
from tox
Change-Id: I69c1c724990aadb7aecabd264382ffd661eb632a

Change-Id: I0402af08e3d1284d1bb00d66fdd8083548c242f2

Add simple script to setup mysql and postgresql databases, this script
can be run by users during testing and will be run by CI systems for
specific setup before running unit tests. This is exactly what is
currently done by OpenStack CI in project-config.
This allows to change in project-config the python-db jobs to
python-jobs since python-jobs will call this script initially.
See also
http://lists.openstack.org/pipermail/openstack-dev/2016-November/107784.html
Needed-By: I0a87f7db0d1d78e7419a8706683aaa540c3dc399
Change-Id: I557202e2be6df2c1cb8efc0f42ac74cd0c458559

For db based drivers, use the Neutron db query hooks mechanism to apply
resource association filters on query results. That improvement permits to
remove two mandatory methods of the driver interface
'find_bgpvpns_for_network' and 'find_bgpvpns_for_router' which can be
replaced by the 'get_bgpvpns' method with appropriated filters.
For non db based drivers, improves utils method to filter resources with
a list of values instead of one value only. In that case, the resource
attribute value must contains filtered values at least (like it's done
for db based drivers).
Change-Id: Icbbb7ba704fbb3c025aabbddbb5121a2ecd852cc
Closes-Bug: #1659895
Implements blueprint api-find-bgpvpn-for-net

See http://lists.openstack.org/pipermail/openstack-dev/2017-January/111295.html
Change-Id: Iede105d4c3d225eca2625afaa98ae007992abf53
Closes-Bug: 1660973

Change-Id: I663c3d91e936f332a3b8a014970ef51e2496b690
Closes-Bug: 1659968

Sphinx module index docs won't be generated unless a
module level docstring is included (ex [1]) with class refs.
As we don't include such module level refs in this project,
nothing is generated and thus no py-modindex.html
is created. This results in a dead link in our devref (see
bug report).
This change removes the modindex ref from our devref's
index to account for this fact. In the future if we wish to
add module documentation to support generation of
modindex we can add the ref back into our index.
[1] https://github.com/openstack/neutron/blob/
master/neutron/neutron_plugin_base_v2.py#L19
Change-Id: I2c7f9a58d398033cf4a8029d16b430fe34fcc56e
Closes-Bug: #1656355 

This patch refactors networking-bgpvpn to use portbindings
from neutron-lib. For more details see [1].
NeutronLibImpact
[1] https://review.openstack.org/422210/
Change-Id: I474141dd063181063715603ec5dd9e07af503288

Change-Id: I67cb55492ec8d1213f84ec32b69df1f15245219b

Change-Id: I329ffa4c6ed7f0fd54a071981ffffb2fe51a05c0

Change-Id: I24692675c8c9e3b8091b975fbab7c553ad3e69ad
Closes-Bug: #1655654 

The following file(s) added utf-8 encoding but never used. So we can
remove them at all.
networking_bgpvpn/__init__.py
doc/source/conf.py
releasenotes/source/conf.py
Change-Id: I3e7667cafae7954fabd84b6ea34f9fead25d8349

This change contains two changes to fix our CI:
- a reno branch naming issue
- a permission issue in devstack VM functional job
On the reno branch naming issue: something must have
changed somewhere in the way we should name branches
in reno files (old way: origin/stable/newton
new: stable/newton).
...
 ldr = loader.Loader(conf)
 File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/releasenotes/local/lib/python2.7/site-packages/reno/loader.py", line 60, in __init__
 self._load_data()
 File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/releasenotes/local/lib/python2.7/site-packages/reno/loader.py", line 80, in _load_data
 self._scanner_output = self._scanner.get_notes_by_version()
 File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/releasenotes/local/lib/python2.7/site-packages/reno/scanner.py", line 577, in get_notes_by_version
 versions_by_date = self._get_tags_on_branch(branch)
 File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/releasenotes/local/lib/python2.7/site-packages/reno/scanner.py", line 344, in _get_tags_on_branch
 for c in self._get_walker_for_branch(branch):
 File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/releasenotes/local/lib/python2.7/site-packages/reno/scanner.py", line 338, in _get_walker_for_branch
 branch_head = self._get_ref(branch)
 File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/releasenotes/local/lib/python2.7/site-packages/reno/scanner.py", line 334, in _get_ref
 raise ValueError('Unknown reference {!r}'.format(name))
ValueError: Unknown reference 'origin/stable/newton'
Change-Id: I22c09534bc713f4eb00d106285a07acdd6e99730

"LOG.warning(_LI" should be "LOG.warning(_LW"
Change-Id: Ib9fbf319bd2f7a955346d95f565958ebf20764aa

Reverts I78543438ccc3c7fedf094c43754489b8aa38f784, now not needed anymore.
Change-Id: I01fb6d2813f1e8433099994b5e9286eaa1b423af
Depends-On: Iede630d4ad1b0de63bc12696b95dc3e2fccc1358

This reverts commit dd4941459c.
The patch for devstack has merged :
I48c86f94098f1501f0e7f90a265dda7e81440eb0
Related-Bug: 1629133
Change-Id: I69907b256af6218c4cfe7aa2b4ba0508991fe4b9

This patch adds a scenario test that creates an l3 VPN and
assigns two neutron networks/subnets to it. Two nova VMs are
spun up on each network. To verify that the VPN is functional,
i.e., forwards traffic between the two subnets, one of the
VM pings the other one.
Change-Id: Ic38aab48fa364ad53ef061566fe5ebc1a46fec33
Closes-Bug: #1637489 

We need to follow devstack change I3d98692e69d94756e0034c83a247e05d85177f02 or
our tempest config addition comes before the config is completely
reset by devstack tempest setup (lib/tempest:configure_tempest rm -rf at [1]).
[1] 0474b8384a/lib/tempest (L177)
Change-Id: I024effd277b90c20c17ae09d291cbadfe5c03f57

ExtensionDescriptor has been rehomed to neutron-lib and is being
removed from neutron core.
See https://review.openstack.org/398113
Depends-On: I5a111e0033e518e39b3042f047ee9eebba77a0d5
Change-Id: I14d55a5b1b419eb39794f5f35bd219d6e83f48f4

The following _MAX_LEN constants are being removed from
neutron/api/v2/attributes.py in [1]. The corresponding DB field size
constants from neutron_lib.db.constants should be used instead.
 NAME_MAX_LEN --> NAME_FIELD_SIZE
 TENANT_ID_MAX_LEN --> PROJECT_ID_FIELD_SIZE
 DESCRIPTION_MAX_LEN --> DESCRIPTION_FIELD_SIZE
 LONG_DESCRIPTION_MAX_LEN --> LONG_DESCRIPTION_FIELD_SIZE
 DEVICE_ID_MAX_LEN --> DEVICE_ID_FIELD_SIZE
 DEVICE_OWNER_MAX_LEN --> DEVICE_NAME_FIELD_SIZE
In alembic migration scripts, the raw numerical value shall be used.
For more information, see [2].
[1] https://review.openstack.org/399891
[2] http://lists.openstack.org/pipermail/openstack-dev/2016-October/105789.html
Change-Id: Iebbed80744d2c4ef89d4255ff36cafa19b68bfb6

This patch adds the team's and repository's badges to the README file.
The motivation behind this is to communicate the project status and
features at first glance.
For more information about this effort, please read this email thread:
http://lists.openstack.org/pipermail/openstack-dev/2016-October/105562.html
To see an example of how this would look like check:
https://gist.github.com/9a6371ba481b5db5194103edf6eb51a0
Change-Id: I0f920daeeadfed8598901cce547e09c7b6c11931

Follow the move of model_base from neutron
to neutron_lib.
Change-Id: Ia726af87f896335e5358df88e6eccab4fea83ee3

(this change also includes, squashed into it,
Ia726af87f896335e5358df88e6eccab4fea83ee3, since
both were needing the other one to pass tests)
Partially-implements: blueprint neutron-lib
Change-Id: I0cbaf59844d026820cb05ed92dbfe8ac9b3a44a4
Depends-on: I7331e914234c5f0b7abe836604fdd7e4067551cf
Change-Id: I0cbaf59844d026820cb05ed92dbfe8ac9b3a44a4

Change-Id: Ic061d62e61d364252fd6f69575fc71c6534e5840

https://bugs.launchpad.net/ironic/+bug/1082248/
Change-Id: I3c5015828ece150fdbceafcefae841888ff38afb

logging.warn is deprecated in Python 3.[1]
[1] https://docs.python.org/3/library/logging.html#logging.warning
Change-Id: Ib0bf744964121ec279cd3ea6fb0ed3dc983c6712

Change-Id: I42587e78a19eab914770c752d0fb57cdbc266fa1