openstack/networking-bgpvpn - networking-bgpvpn - OpenDev: Free Software Needs Free Tools

This change is needed to have the OVS agent extension for the bagpipe
driver enabled (because of [1]).
[1] https://github.com/openstack/neutron/blob/stable/newton/devstack/lib/l2_agent#L12
Change-Id: I1f4c86a6ae15985e581d0fd0a03754b2c5a5d571

How to configure the bgpvpn plugin for devstack is not
written in the doc.
Change-Id: I45082d20b83cf368901545a373f1c20368aeee13

Using the horizon UT framework will simplify our dashboard
test and avoid issue due to horizon future evolutions
Change-Id: I719a9912ba8e7fe87620850017bdda83431e22da

Our UTs related to resource creations test the result of the creation
API call. Neutron recently introduced the patch
I8775aa8a477191ef21e7c3c6da31d098befefc3c which automatically adds the
project_id and tenant_id to any create API call, and then breaks out UTs.
This patch relaxes our UTs by only testing that expected values are part
of the response to a resource creation API Call.
This patch fix another issue in the gate introduced by
I59cbd8bff117813258539ed0724fe89a9f5b77ee
Our horizon test framework needed an adaptation.
Change-Id: I320bcbf16ce9c30fca8821fe9e9202514bec1b6e

This fix enables BGP L2-type VPNs to be passed over to
OpenDaylight.
The upcoming Carbon release of OpenDaylight will start
supporting L2 BGPVPNs (Or Ethernet VPNs).
Change-Id: I8cc8659dc5ba5365ec4cf8872512201a496b5d4c
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>

Change-Id: I3dbd54364165b489871214b308a18c7b4a71f91d
Partial-Bug: #1607664 

* Improve the set of tests to be more exhaustive. The goal of these tests is
 to check that the reading restrictions between user of different tenants
 are preserved.
* The tests added are:
 * show bgpvpn object made by a non owner fail.
 * show network association made by a non owner fail.
 * list network associations made by a non owner fail.
* Add new methods to the BgpvpnClient (list, show).
* Rename some methods/calls to be more standard.
Change-Id: I7a3d773b30aa4ceaf13022f200f6fc6a49934ec2
Partial-Bug: #1607664 

NotImplementedError is the name of the exception
(https://docs.python.org/2/library/exceptions.html).
NotImplemented is the name of a constant
(https://docs.python.org/2/library/constants.html).
>>> raise NotImplemented()
Traceback (most recent call last):
 File "<pyshell#31>", line 1, in <module>
 raise NotImplemented()
TypeError: 'NotImplementedType' object is not callable
>>> raise NotImplementedError()
Traceback (most recent call last):
 File "<pyshell#32>", line 1, in <module>
 raise NotImplementedError()
NotImplementedError
 This patch fix it.
Change-Id: I5f38f34f59ffed87baa9269aa0f7b848bcacc8fa
Closes-Bug: #1339855 

Similarly as in I02b28d3b354c3b175147c5be36eea4dc7e05f2a3 .
Change-Id: Ia8fd880e6a4dda080befedc4a85a9fa7b55f7772

Not sure why pep8 didn't complain at merge time, but it is
complaining now in my setup.
Change-Id: I5fe65c47a4ace13e21741804730c5815b4e2b32d

(required to avoid a deprecation warning)
Change-Id: Ie611cbdc25fb1fcea67e16d11a45307a708cab92

Catch the exception raised by the UUID library in the case of a
malformed UUID and raise an OpenContrailMalformedUUID managed by
Neutron server logs.
Change-Id: I05dc8a380a3e5a8d54f21cef186cb532ec9461f2
Closes-Bug: #1604748 

* Configure the second openstack user by providing the "alt"
 client_manager.
* Add the test function which checks that a user cannot read
 bgpvpn resources that it does not own.
* Add some comments in the BgpvpnTest description.
Change-Id: Ia1edea9f414384a59b0568d0d733e3413944bd05
Partial-Bug: #1607664 

Test checks that invalid route targets are rejected by the create and update api.
Test checks that invalid network,bgpvpn id are rejected by the associate and disassociate api.
Change-Id: I181a1876f654ce5821c6bc212696d7be2801acde
Partial-Bug: 1607664

Change-Id: Ibd2f50797b4d6c6b34cda6bf3f219644af0ffe43
Partial-Bug: #1607664 

now that they haved moved out of neutron repo,
import api validators/converters from neutron_lib
Change-Id: I9f333f69533da5f4632e89aab5194f8ee5d216e5
Signed-off-by: Morgan Richomme <morgan.richomme@orange.com>

remove override of DEVSTACK_GATE_TEMPEST that is defined in jenkins job,
and run only bgpvpn's tempest tests using a regex filter.
Change-Id: Iae534db7bd34624fad135dad4f5b6f34fc5143bf

Since I1d633810bd16f1bec7bbca57522e9ad3f7745ea2 has merged we have a few
unit test failing because our Ports are not created with the same tenant_id as
the one specified in our 'context'.
This patch forces the use of the generic Neutron test tenant id everywhere.
Change-Id: I8c28c061ce091acf07d221b0b2bf0eb003f9e7d8

Change-Id: I984adf767ffaf60a43df1baa97a377b55f95eaf5
Signed-off-by: davidblaisonneau-orange <david.blaisonneau@orange.com>

Only in the opencontrail driver (as other neutron resource creation)
Improve the opecontrail_client by adding the 'project' resource
Add a function that check the tenant ID by reading (show) the project
Made the check in bgpvpn 'create' and 'update' functions
Change-Id: Iedea7863bed39d9a8f4bff1e2fa647bdd45ba3a5
Closes-Bug: #1604748 

Now that the tenant_id rename has merged in Neutron we can
remove the temporary work-around.
Also switch from the deprecated models_v2.HasId to the relocated
model_base.HasId
Related Blueprint: keystone-v3
Change-Id: I83c04e3455deade9ed1dda823d1a321579fba808

Many deprecations are triggered early (on imports, for example)
before the warnings are enabled by the WarningsFixture in the
base test class.
To make sure all DeprecationWarning messages are emitted we enable
them via the PYTHONWARNINGS environment variable.
Change-Id: Id88216090ea0ebdf9c1353eb713ccfed72c84630

Network assocation and disassociation client functions have also been
added.
Change-Id: I5494c3f7c85105bc22e508e09d2c32a09d664477
Partial-Bug: #1607664 

This two files were given execution permission
by mistake. This patch removes the error permission.
Change-Id: Iba2f54ab1fd7ec36011dc1873322859322d6c001

Now that there is a passing gate job, we can claim support for
Python 3.5 in the classifier. This patch also adds the convenience
py35 venv.
Change-Id: I2e656f961b1f29d1aa64ae6e06ac0598186c4144

Updated from global requirements.
TrivialFix.
Change-Id: I623fd853eee29e1ed1ea28bb56731f2aba34fb65

Change-Id: Ic5c56906652de54e7d01f70044c6517d7393b40c

It's only needed for python < 2.7 which is not supported.
Change-Id: I98a7b99f65faa3a7db6a6a1ac99626644347b39b

The admin creates a bgpvpn resource by specifying a normal user tenant
id. Test checks this user fails to delete the bgpvpn resource.
Change-Id: I2d3f91b9d7ab86187e842f6dbecfa51ef9afbe8e
Partial-Bug: #1607664 

All occurences of ``tenant_id`` across the neutron database are
being renamed to ``project_id``.
This neutron-fwaas change accompanies the neutron change:
I87a8ef342ccea004731ba0192b23a8e79bc382dc
Change-Id: I017b3f8ec432f1d334879f30026d8b16f6295eff
Partially-Implements: blueprint keystone-v3

Bring the sqlalchemy models in sync with the alembic migrations.
Add the neutron standard model-migration sync test. The test is
added to the unit test env since bgpvpn does not have a
functional job yet. This requires that bgpvpn uses the
python-db-jobs template in the gate.
The neutron HasTenant model mixin includes an index for the
tenant_id column, but bgpvpn's alembic migrations never created
those indexes. So here we include a migration to add them.
(Also clean up some unused parameters and __init__ files.)
Closes-Bug: #1605608
Partial-Bug: #1604803
Depends-On: I3a8ea02b86846e9a8a7d7f2aee9700ca952b0248
Change-Id: I24d35f7dccab611143f4b0a7428ba7074f2adcc2