openstack/networking-bgpvpn - networking-bgpvpn - OpenDev: Free Software Needs Free Tools

Change-Id: I9b6fc742cfca20467c891a5e276326c76d1a8cf8
Signed-off-by: Ivan Anfimov <lazekteam@gmail.com>

Python 3.8 support was already removed so it should no longer be in
the default envlist. Also use unversioned target instead of versioned
ones so that we don't have to update the envlist when supported python
versions are updated.
Change-Id: Idf99246ae8c28d26eb4272c41b9cf38cc56f9940

Use pylint 3.2.0 on Noble.
Change-Id: I30f5c19ff9933b14cd887822c83213e7d0c285a0

hacking 3.0.x is too old.
Try to synchronize pylint ignore and extension list with
other Networking projects.
Change-Id: I93206052a384ceaf182ff3a93a326e17b2110a4d

tox now always recreates an env although the env is shared using envdir
options.
~~~
$ tox -e genpolicy
genpolicy: recreate env because env type changed from
{'name': 'genconfig', 'type': 'VirtualEnvRunner'} to
{'name': 'genpolicy', 'type': 'VirtualEnvRunner'}
~~~
According to the maintainer of tox, this functionality is not intended
to be supported.
https://github.com/tox-dev/tox/issues/425#issuecomment-1011944293
Change-Id: I74c5c05679a3e9ecf376634fac34a9269a1e9cba

Change [1] modified the tox.ini file in a way that it builds now
a regular Python package and installs it into virtual environment
instead of using the editable module. The current configuration
also breaks the behavior under tox version 3, where skipsdist option
could be set only on top level of tox.ini file.
[1] https://review.opendev.org/c/openstack/networking-bgpvpn/+/868072
Change-Id: I0bc8c30d58cc12c15cf657f2699f40641174c63c

With tox4 allowlist_externals is more strictly checked, so
fix it where necessary and fix pylint version.
Depends-On: https://review.opendev.org/c/zuul/zuul-jobs/+/866943
Related-Bug: #1999558
Change-Id: I7a4fed13cf6d04609f2e2e074a4c6fc8d17107d4

Adopt dsvm-functional target name as [0] changed in Neutron, so the new
name of the target is dsvm-functional-gate.
[0]: https://review.opendev.org/c/openstack/neutron/+/856262
Depends-On: https://review.opendev.org/c/openstack/neutron/+/857680
Change-Id: I94ce9515c6620471a15f415b4daf450666c0ecde

As discussed in TC PTG[1] and TC resolution[2], we are
dropping the lower-constraints.txt file and its testing.
We will keep lower bounds in the requirements.txt file but
with a note that these are not tested lower bounds and we
try our best to keep them updated.
[1] https://etherpad.opendev.org/p/tc-zed-ptg#L326
[2] https://governance.openstack.org/tc/resolutions/20220414-drop-lower-constraints.html#proposal
Change-Id: Id8912276036fe3b3a753ba0d3b860aa86e7759de

The patch bumps min version of tox to 3.18.0 in order to
replace tox's whitelist_externals by allowlist_externals option:
https://github.com/tox-dev/tox/blob/master/docs/changelog.rst#v3180-2020年07月23日
Change-Id: I2e2574ab495a4e8dd10f81315996844f93645895

UPPER_CONSTRAINTS_FILE is old name and deprecated
This allows to use upper-constraints file as more
readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>.
Change-Id: I0c8c2c4a783c4f0ac9f7530d4d18937ce5b17c61

in 'victoria' cycle, we should test py38 by default.
[1] https://governance.openstack.org/tc/reference/runtimes/victoria.html
Change-Id: I023720594810d346649fcda24ce011ce15955fc6

Make the code compatible with hacking rules:
* import order problems
* line break before/after binary operator (for this added ignore for
W504, line break after binary operator
* indentation problems
I removed the rule N530 (Direct neutron imports not allowed), as that is
a longer story.
As a side-effect use newer pylint version, and fix the problems reported
Change-Id: I701c89ecc890a1d866815b5401cd4c022c51c9c4
Depends-On: https://review.opendev.org/#/c/708965/ 

Remove unnecessary things from tox.ini:
- install_command: it's better to use the built-in install command
- VIRTUAL_ENV: this is set anyways
- sitepackages: it's enough to use virtualenv's packages
Besides these seem to be unnecessary 'sitepackages' setting started to
break functional job with an error message that there are missing
packages, however those were installed. By removing sitepackages=True
setting the errors dissapear.
Closes-Bug: #1876028
Change-Id: Ifc4904fa89eb7fcaaa8cd623112f419ac57ea286

Django 1.11 ends its extended support in April 2020 (which is before
Ussuri release), so horizon drops Django 1.11 support in Ussuri.
tox envs for non-primary Django versions are no longer needed in tox.ini
as testing environments for non-primary Django versions are setup in
the zuul jobs now.
horizon>=17.1.0 is required to use Django 2.2. requirements.txt and
lower-constraints.txt are updated accordingly. for more info. please
refer [1].
Depends-On: https://review.opendev.org/#/c/700733/
[1] https://etherpad.openstack.org/p/Enable_Django22_support_in_Horizon_Plugin
Change-Id: Icdd22683361a56a366af5d8d5c9b082e98abbe21

OpenStack is dropping the py2.7 support in ussuri cycle.
networking-bgpvpn is ready with python 3 and ok to drop the
python 2.7 support.
Also this patch update minimum tox version and remove 'pypy' entry
as it is no longer run in tox.ini file.
Complete discussion & schedule can be found in
- http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010142.html
- https://etherpad.openstack.org/p/drop-python2-support
Ussuri Communtiy-wide goal:
https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html
Change-Id: Id8046ef85da72207097fef52b7966a4b3a067704

For more detail, see http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006478.html
Change-Id: I52fb104a9ebeef3a51dcf014434d7f8bc28abcc9

Horizon defined a project template 'horizon-non-primary-django-jobs'
for django jobs. This patch use that template to run django jobs
here. For information please refer [1]
[1] https://review.opendev.org/#/c/681969/
Change-Id: I99604ffa2a93f4df52ae143e54aeec95201230b2

The content of the top page is adjusted to fit both HTML and PDF docs.
Story: 2006099
Task: 35122
Change-Id: Id97ac873c5593d273f1eb66000b21899a5caa33d

This is a mechanically generated patch to ensure unit testing is in place
for all of the Tested Runtimes for Train.
See the Train python3-updates goal document for details:
https://governance.openstack.org/tc/goals/train/python3-updates.html
Change-Id: Ib0ce018cf8f70fce05d53c4815ae34d764f7ef34
Story: #2005924
Task: #34225 

We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: Iafddd120e35bcec814be5a35d901b4102da5f8e2

This patch removes all tempest tests from networking-bgpvpn repository
as all of them are now moved to neutron-tempest-plugin repo.
It also removes job legacy-tempest-dsvm-networking-bgpvpn-bagpipe which
is now replaced by job neutron-tempest-plugin-bgpvpn-bagpipe defined in
neutron-tempest-plugin repo directly.
Depends-On: https://review.opendev.org/#/c/652991/
Change-Id: Iaccf6db5c2bd248c2758168340e83f936e9eb8ea

Change-Id: Ieb2be8c2466ef762509a644c14fb4e9c26d82253

All the integration testing has been moved to
Bionic now[1] and py3.5 is not tested runtime for
Train or stable/stein[2].
As per below ML thread, we are good to drop the py35
testing now:
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/005097.html
[1] http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004647.html
[2]
https://governance.openstack.org/tc/reference/runtimes/stein.html
https://governance.openstack.org/tc/reference/runtimes/train.html
Change-Id: I537cdb447953e538302fa9107fa56b1461bfe1c6

We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I380c7b2010248a257612ad707a69b433054d7a4a
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Change-Id: I9942c525dc0235750ca531e983b7f4ad248c7e14

Fixes a few pylint warning from this recent pylint.
len-as-condition, inconsistent-return-statements and
no-else-return rules are
added to the ignore list in .pylintrc because they are
patterns commonly used in the neutron stadium and
already ignored in the neutron repo.
Change-Id: Ib8f25b8103f6bb429cf5fbaa7a071dab7326930f
Co-Author: Akihiro Motoki <amotoki@gmail.com>

This commit converts the existing networking-bgpvpn policy.json
into policy-in-code.
Partially Implements: blueprint neutron-policy-in-code
Change-Id: I7cee0efef016dd8650ccf97686fe680667d52683

The commands used by constraints need at least tox 2.0. Update to
reflect reality, which should help with local running of constraints
targets.
Change-Id: Ib69b92df3d8cf0566b01b96d1cc79f6bb6b599d1
Closes-Bug: #1801463 

This patch adds local tox targets for pep8 and python 3 as per [1]
that will install dependencies in editable mode.
To run them use the pep8-dev and py3-dev targets respectively.
[1] https://etherpad.openstack.org/p/neutron-sibling-setup
Change-Id: I27fd4d41fa66924507d58a980813d150b5299e1b

Update to new PTI:
https://governance.openstack.org/tc/reference/pti/python.html#python-test-running
This change also wraps in a change to requirements.txt that
point pre-rocky neutron pypi release, which is the only
way I found to have the functional job get a fresh-enough
neutron (it's not a tox job and hence does not benefit
from the tox-siblings magic). This also reflects better what
is the real dependency we have (when rocky will ship we will
have neutron>=13.0.0.0).
Change-Id: I868cf65aa5ff0e55d0d45f36808c76286e4e7fd3

Django 2.0 is now used in tox py35 job, so there is no need for
py35dj20 job. Instead, Django 1.11 with python3 is not covered.
- py35dj20 job is dropped from tox.ini.
- python3-django111 is added to tox.ini.
 python3 is specified to basepython to avoid a specific python version.
- .zuul.yaml is updated to consume horizon-openstack-tox-python3-django111
 and drop horizon-openstack-tox-py35dj20.
Change-Id: Iba72d0bd67d6d6331b1abcfa338d02a8f4070562

Replaces django.core.urlresolves with django.urls.
(In Django 2.0) The django.core.urlresolvers module is removed
in favor of its new location, django.urls.
It was deprecated in Django 1.10:
https://docs.djangoproject.com/en/2.0/releases/1.10/#id3
The arguments of include() has been changed in Django 1.9
and the older style was dropped in Django 2.0.
https://docs.djangoproject.com/en/2.0/releases/1.9/#passing-a-3-tuple-or-an-app-name-to-include
Add py35dj20 job to test Django 2.0 integration.
Change-Id: I1cdfc19c9fae5cad1adac0867f65d2ae15385d87

Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: I8596b2a4d38c43cfa18e4dfa0c15990326ecc75c
Depends-On: https://review.openstack.org/555034
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Instead of using tox-install.sh, we can install horizon and neutron
etc. now directly from pypi - or use the current branch in CI system using
tox-siblings.
Create doc/requirements.txt for doc requirements as well.
Update tox.ini for this change and add projects to test-requirements
file.
Note this is one step in fixing publishing of docs for this repository.
Depends-On: https://review.openstack.org/552865
Depends-On: https://review.openstack.org/554297
Change-Id: I13e61fffca48b6c004e028f0da8a1d84a2337e10

Auto-generation of configuration files is part of the community-wide
doc-migration effort in Pike. networking-bgpvpn does not support it,
so this commit sets up the config file autogeneration.
Change-Id: I9c7bc3097bbaef1990b1b9e5f23771cef99fd016

neutron library has a good hacking rules set, we can use these rules
instead of reinvent the wheel. These such rules are:
- [N521] Validate that jsonutils module is used instead of json
- [N532] Validate that LOG.warning is used instead of LOG.warn. The latter is deprecated.
- [N537] Don't translate logs.
- [N534] Exception messages should be translated
Change-Id: Icefb263a5d3fb3622fd40e78e0a01d6d7fc0f22b

According to [1], we can passing a "-t" argument to
oslo_debug_helper to indicate the directory where tests
are located. This will solves ImportError exception.
[1] https://docs.openstack.org/developer/oslotest/features.html
Change-Id: I0e4b2707a4f9bd6b1449624ba585ece5dab7c451
Closes-Bug: #1666560 

The gating on python 3.4 is restricted to <= Mitaka. This is due to
the change from Ubuntu Trusty to Xenial, where only python3.5 is
available. There is no need to continue to keep these settings.
This patch add support python 3 to classifier and drop py34 environment
from tox
Change-Id: I69c1c724990aadb7aecabd264382ffd661eb632a