Upgrade pylint to a version that works with python3
Fixes a few pylint warning from this recent pylint. len-as-condition, inconsistent-return-statements and no-else-return rules are added to the ignore list in .pylintrc because they are patterns commonly used in the neutron stadium and already ignored in the neutron repo. Change-Id: Ib8f25b8103f6bb429cf5fbaa7a071dab7326930f Co-Author: Akihiro Motoki <amotoki@gmail.com>
This commit is contained in:
8 changed files with 14 additions and 11 deletions
@@ -44,13 +44,16 @@ disable=
# "C" Coding convention violations
bad-continuation,
invalid-name,
len-as-condition,
missing-docstring,
superfluous-parens,
# "R" Refactor recommendations
abstract-class-little-used,
abstract-class-not-used,
duplicate-code,
inconsistent-return-statements,
interface-not-implemented,
no-else-return,
no-self-use,
too-few-public-methods,
too-many-ancestors,
@@ -13,11 +13,12 @@
# License for the specific language governing permissions and limitations
# under the License.
import os
import sys
from keystoneauth1.identity import v3
from keystoneauth1 import session
from neutronclient.v2_0 import client
import os
import sys
# Parameter for subnet neutron object
SUBNET_IP = "192.168.24.0/24"
@@ -3,7 +3,7 @@ alembic==0.8.10
amqp==2.1.1
appdirs==1.3.0
asn1crypto==0.23.0
astroid==1.3.8
astroid==1.6.5
Babel==2.3.4
beautifulsoup4==4.6.0
blockdiag==1.5.3
@@ -111,7 +111,7 @@ pycparser==2.18
pyflakes==0.8.1
Pygments==2.2.0
pyinotify==0.9.6
pylint==1.4.5
pylint==1.9.2
pymongo==3.0.2
PyMySQL==0.7.6
pyOpenSSL==17.1.0
@@ -19,7 +19,7 @@ BGPVPN_RES = bgpvpn.BGPVPN_RES
BGPVPN_L3 = bgpvpn.BGPVPN_L3
BGPVPN_L2 = bgpvpn.BGPVPN_L2
BGPVPN_TYPES = bgpvpn.BGPVPN_TYPES
UINT32_REGEX, = bgpvpn.UINT32_REGEX,
UINT32_REGEX = bgpvpn.UINT32_REGEX
UINT16_REGEX = bgpvpn.UINT16_REGEX
UINT8_REGEX = bgpvpn.UINT8_REGEX
IP4_REGEX = bgpvpn.IP4_REGEX
@@ -28,6 +28,8 @@ from neutron_lib.db import api as db_api
from neutron_lib import exceptions as n_exc
from neutron_lib.plugins import directory
from networking_bagpipe.objects import bgpvpn as bgpvpn_objects
from oslo_log import helpers as log_helpers
from oslo_log import log as logging
@@ -35,7 +37,6 @@ from networking_bgpvpn.neutron.extensions import bgpvpn as bgpvpn_ext
from networking_bgpvpn.neutron.services.common import utils
from networking_bgpvpn.neutron.services.service_drivers import driver_api
from networking_bagpipe.objects import bgpvpn as bgpvpn_objects
LOG = logging.getLogger(__name__)
@@ -306,9 +306,6 @@ class BGPVPNDriverRCBase(BGPVPNDriverBase):
more_supported_extension_aliases = [
bgpvpn_rc.Bgpvpn_routes_control.get_alias()]
def __init__(self, *args, **kwargs):
super(BGPVPNDriverRCBase, self).__init__(*args, **kwargs)
@abc.abstractmethod
def update_router_assoc(self, context, assoc_id, router_association):
pass
@@ -14,7 +14,7 @@ stestr>=1.0.0 # Apache-2.0
testresources>=2.0.0 # Apache-2.0/BSD
testscenarios>=0.4 # Apache-2.0/BSD
testtools>=2.2.0 # MIT
pylint==1.4.5 # GPLv2
pylint==1.9.2 # GPLv2
tempest>=17.1.0 # Apache-2.0
# OpenStack CI will install the following projects from git
3
tox.ini
3
tox.ini
@@ -24,6 +24,7 @@ deps = -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/re
commands = sphinx-build -W -a -E -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html
[testenv:pep8]
basepython = python3
deps =
{[testenv]deps}
commands =
@@ -146,4 +147,4 @@ deps =
{[testenv:pep8]deps}
commands =
{[testenv:dev]commands}
{[testenv:pep8]commands}
{[testenv:pep8]commands}
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.