openstack/networking-bgpvpn - networking-bgpvpn - OpenDev: Free Software Needs Free Tools

As discussed at the Epoxy PTG meeting, run an automated
upgrade tool to make code python 3.9+ compliant.
Result of running:
$ pyupgrade --py39-plus $(git ls-files | grep ".py$")
Fixed PEP8 errors introduced by pyupgrade by running:
$ autopep8 --select=E127,E128,E501 --max-line-length 79 -r \
 --in-place networking_bgpvpn
Also did manual updates as necessary to fix other errors
and warnings after above commands.
Inspired by Octavia and Nova [0].
[0] https://review.opendev.org/c/openstack/nova/+/896986
Change-Id: Iac7a039ad6924de14aba8f391ff904785c089df7

These are no longer required by recent Babel, and the same were removed
from neutron some time ago[1].
[1] 57fc472b334260358623322d03ca38f4620272e5
Change-Id: I71532a452c57339aa636a89bdf2d014eace12bf2

These are optional so should not be part of the requirements which are
always installed. Also fix the inconsistent lower constraints of
horizon described in different files.
Change-Id: I97fb056d8519d7020720b11484cf6cf03ef87090

Python 3.8 was removed from the tested runtimes for 2024.2[1] and has
not been tested since then. Bump the minimum version to avoid being
installed in Python 3.8 .
[1] https://governance.openstack.org/tc/reference/runtimes/2024.2.html
Change-Id: Ib932cdc49284de1c8b3b12ef714f9f90a554fa6e

Based on [0] only py39 and py312 jobs are in the testing
runtime for 2025.1, updated relevant files accordingly.
[0] https://review.opendev.org/c/openstack/governance/+/926150
Depends-on: https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/926153
Depends-On: https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/929823
Change-Id: I93c19988e02f81a06a90fa9a7412c6b83249cd4f

The SQLAlchemy 2.0 migration is concluded and there is no need to keep
the jobs testing the main branch anymore.
Change-Id: Ic5c87838eea24b5c3122e1914960be61d8ac45b0

Add file to the reno documentation build to show release notes for
stable/2024.2.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2024.2.
Sem-Ver: feature
Change-Id: I751da469a41e37af0f901ab003021dcb3c421c92

sphinxcontrib-blockdiag, sphinxcontrib-nwdiag and
sphinxcontrib-seqdiag projects are no longer maintained, see [1].
Remove these from the dependencies list and use png images
instead of building them from blockdiag files.
To keep the original source I do not delete the *.blockdiag files.
[1]: https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/4IID4UEXY4PJJGBTMFMTRYLKJIN4GOQ6/
Change-Id: I792d18e2dd6771a6f7eabfeb621c9efc4b47901f

'pre-commit' tool [1] provides an extensible way to configure hooks
which can be run automatically before each commit. That way we can make
sure that code send to review is passing base static analysis checks
like e.g. bandit, flake8 or hacking.
For now this is optional to use and not integrated in e.g. tox.ini file
but we can integrate it there too as next step.
[1] https://pre-commit.com/
Change-Id: Ic3ec4d699b80d2e31fa8d52da71069b3f1104d9b

TrivialFix
Change-Id: I47c32bdd9928a300176ae36a8e530f99562ee596

Those changes are done just to make pre-commit hook happy.
TrivialFix
Change-Id: I8e21f41626bcd34c7ff490ea9ac6d7eb40316013

Update the wallaby release notes configuration to build from
unmaintained/wallaby.
Change-Id: I0e29f218f3f14bcf3f33a951bb19c101ee3954dc

* The str(url) function in SQLAlchemy hides the password. For a URL
 string that is to be re-used, use
 render_as_string(hide_password=False) .
* subtrasactions was removed in SQLAlchemy 2.0[1].
[1] https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#migration-to-2-0-step-five-use-the-future-flag-on-session
Co-Authored-By: Mike Bayer <mike_mp@zzzcomputing.com>
Change-Id: I9c7539f26ad58ad62661f98d125ba5495e7ac271

... because LF is commonly used as newline code.
Change-Id: If238971837e7732068bb935c16b2a9a160d9a9a1

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: If0161b63916e76683494328382e450c5767071b1

Based on [0] & [1] only py39, py311 and py312 (non-voting)
jobs are in the testing runtime for 2024.2, updated relevant
files accordingly.
[0] https://review.opendev.org/c/openstack/governance/+/908862
[1] https://governance.openstack.org/tc/reference/runtimes/2024.2.html
Change-Id: If02b2a8f87cc13eaada5b045881e569e58defe5b

Add file to the reno documentation build to show release notes for
stable/2024.1.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2024.1.
Sem-Ver: feature
Change-Id: I337f71b5faf43442eb8d91851e796cf286002bd7

Update the xena release notes configuration to build from
unmaintained/xena.
Change-Id: I9637c7b1eff43979ae4bd681523cdb7d132dc2ee

Update the victoria release notes configuration to build from
unmaintained/victoria.
Change-Id: Ie1e4b8307bae54532cb24fdec9392361c11ec6a2

hacking 3.0.x is too old.
Try to synchronize pylint ignore and extension list with
other Networking projects.
Change-Id: I93206052a384ceaf182ff3a93a326e17b2110a4d

tox now always recreates an env although the env is shared using envdir
options.
~~~
$ tox -e genpolicy
genpolicy: recreate env because env type changed from
{'name': 'genconfig', 'type': 'VirtualEnvRunner'} to
{'name': 'genpolicy', 'type': 'VirtualEnvRunner'}
~~~
According to the maintainer of tox, this functionality is not intended
to be supported.
https://github.com/tox-dev/tox/issues/425#issuecomment-1011944293
Change-Id: I74c5c05679a3e9ecf376634fac34a9269a1e9cba

Update the yoga release notes configuration to build from
unmaintained/yoga.
Change-Id: I703162937c60e0b623ccbe2410a15801e50eb42d

The networking-bgpvpn/openstack directory does not exist.
Change-Id: Ieb962c002030cf1f78e1c37dd45de72e6a66a0b5

... because the service was removed long ago.
Change-Id: I42d6fb39976b7aaf8e24b443dc548d4d110964b2

None of these files need to be executable.
Change-Id: I65e80a4b2a1136558c060da46b22189c1ed50c7d

With django 4 some of the imports were changed, adopt
bgpvpn_dashboard to these changes.
Change-Id: If2728626f227a8cb4023cb2395c4c440e92347db

Change-Id: I2d4cb37d9e6bec6eec6dcd4978266bc8fd1388de

Change-Id: I2405bf23cbebd103f4c4566359e0dcd39d421401

Add file to the reno documentation build to show release notes for
stable/2023.2.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.2.
Sem-Ver: feature
Change-Id: Ie57176f70562e14028f5c91c4064c567ba758819

In 2023.2 cycle testing runtime, project test in py38 py39 and py10
[0] https://governance.openstack.org/tc/reference/runtimes/2023.2.html
Change-Id: I6e2ffe6f30f8fd5f82fef893b2edfee2705b6a16

Python 3.11 job run on Debian Bookworm which does
not the mysql pkg for example, mariadb-server, libmysqlclient-dev
instead they have mariadb. Updating bindep.txt file
to adjust the pkgs as per Debian bookworm.
Copy-paste of
https://review.opendev.org/c/openstack/networking-bagpipe/+/893987
Change-Id: I42a369ebe8079b901a37ac44e117006ccb98ae9d

Change [1] modified the tox.ini file in a way that it builds now
a regular Python package and installs it into virtual environment
instead of using the editable module. The current configuration
also breaks the behavior under tox version 3, where skipsdist option
could be set only on top level of tox.ini file.
[1] https://review.opendev.org/c/openstack/networking-bgpvpn/+/868072
Change-Id: I0bc8c30d58cc12c15cf657f2699f40641174c63c

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I24900290582a52b5d4ca0fcb68868c935b2222a8

[1] made neutron-tempest-plugin-bgpvpn-bagpipe job temporarily
non-voting, as both the networking-bagpipe and networking-bgpvpn
fixes are merged the job can be voting again.
[1]: https://review.opendev.org/c/openstack/networking-bgpvpn/+/883057
Change-Id: Idafcd5425d5339c3ff0788f26260a78e7c14c169
Related-Bug: 2019097
Depends-On: https://review.opendev.org/c/openstack/networking-bagpipe/+/883064 

neutron recently merged a commit enabling secure rbacs by default [1]
breaking several unit tests of networking-bgpvpn.
This patch changes the necessary test calls to be admin and
requires neutron >= 23.0.0.0b2.
[2] removed neutron.debug, remove the dependency to it in
service_drivers.bagpipe.bagpipe and in test_bagpipe.
Make neutron-tempest-plugin-bgpvpn-bagpipe job temporaryly
non-voting, when this patch and the bagpipe one depending on
this one (see [3]) are merged we have to set the job back to
voting.
[1]: 670cc383e0
[2]: https://review.opendev.org/c/openstack/neutron/+/883081
[3]: https://review.opendev.org/c/openstack/networking-bagpipe/+/883064
Depends-On: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/883838
Related-Bug: 2019097
Change-Id: I5c3070cd385307a46a9cea39e37276d4d888bd1b

Add openstack-tox-py39-with-oslo-master to periodic weekly and as an
extra simplify the required projects with anchor.
Add openstack-tox-py310-with-sqlalchemy-master job to weekly queue.
Change previous jobs in the periodic to py310
Related-Bug: #2004265
Change-Id: I043c657052c9fa43fcef4636362477d16551c337

Change-Id: I04ea4f02b3e1cdd22c07b8d458a5e011620b5e39