openstack/codegenerator - codegenerator - OpenDev: Free Software Needs Free Tools

Certain octavia operations (failover) return 202 with empty body.
Address this in the schema, so that also the cli commands do not fail
expecting a body.
Change-Id: Id19511311c82a9381aa1eb120cc64a644f346f89
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

Per HTTP/2.0 header names must only contain lowercase characters,
numerals and symbols.
Change-Id: I62806d01d53754de95afe16e5a8d95580cc8b5a7
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

Static strings are heavily complicating the headers management. Switch
to Into<HeaderName> and Into<HeaderValue> instead.
Change-Id: Iea470a5dd5950f155469e5de0ec4a3c3f70f39ae
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

All dns list/get operations support `x-auth-all-projects` and
`x-auth-sudo-project-id` headers, which can be used by admins.
Change-Id: Ic5a7cd6c0312a6ac28d895c290924621943e598a
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

As explained in the documentation `arrays` have an `items` section, and
arrays that can have arbitrary values are defined like this [1]:
```
type: array
items: {}
```
In the cinder schemas we have a couple of cases where we are defining an
`array` without `items`, all other arrays in the openapi codebase seem
to be right.
In this patch we fix these issues and introduce code in the
`_sanitize_schema` to detect future cases of this issue and fix the
schema automatically for the output.
[1]: https://swagger.io/docs/specification/v3_0/data-models/data-types/#mixed-type-arrays
Change-Id: I49cadcccf64ed9699a4b41674109b4afbfa1e106

Glance defines metadata property of the image location as mandatory
while in devstack it is not present. Hardcode a dirty fix for the
schema.
Change-Id: I15f2f0a543174eccbeb5c0d4da9e5222ce1e5d7a
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

Change-Id: Id87bf2700e6ddc9183e924f8c9cf6b9f53a44baa
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

I assume this is the intention.
Change-Id: I622731b4cbd2727c38c82348f47a4692964281b9
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Rename "limit" query parameter of the list operations to "page-size" for
giving precise meaning (keep alias "limit"). This is necessary to
finally resolve the conflict that we have in the python-openstackclient
where "limit" means a page size and all entries are fetched unless you
also specify the marker (which is not something anybody can really
understand why).
Change-Id: I9a6ddcbe30d92c4d190229ac77a10c28eb0015fb
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

The fix was merged so we should enforce the identity openapi job now.
Change-Id: Ic482c7e0e8444a415a5fe5e3c3a801884447006f
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

Change-Id: I9d8b5ee8f860c6de6ca2006ec85f9bb8f7a02e47

When generating the nova AZ detail schema we are adding examples to the
`hosts` object, but we are doing it wrong:
- We are adding a dictionary instead of a list, which is what the plural
 form of example indicates and also what we can see in the OpenAPI spec
 documentation [1].
- The contents of the example are wrong, it shouldn't have the `JSON
 request` key, as we can see in the upstream docs [2].
This patch fixes the examples to be correct.
[1]: https://swagger.io/specification/#model-with-example
[2]: https://docs.openstack.org/api-ref/compute/#get-detailed-availability-zone-information
Change-Id: Ic694ee083f55d44d0ecdb8a72561e24ec1b70583

It can happen (in Keystone it does for sure) that certain API method
decorators when applied together result in certain schemas being present
in multiple decorator processing iterations. This results in some
schemas being multiplied. It should be safe to just use `set` instead of
a `list` to deduplicate them.
While we were working on this Nova "again" changed some decorators
breaking us so fix that as well since generated code is broken.
Change-Id: I25b2506264d6027f9d605c74297e6f0cc6ab2767
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

In addition to that fix the new issue in the compute schemas with enum
without type.
Make identity job to non-voting to temporarily bypass a deadlock and
land the fix.
Change-Id: I7f5f967824e338477a6979e34c2100433458e7c1
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

When exporting OpenAPI in YAML format we are exporting in YAML version
1.2, which is the latest. The problem with that is that there are tools
that use the PyYAML [1] python package to read these files, and that
package only supports YAML v1.1, which will lead to reading things
incorrectly.
An example is with booleans.
In v1.1 a lot of values are considered as booleans (case insensitive):
true, false, 1, 0, off, on, no, yes... But in v1.2 only true and false
are considered booleans, so the others don't need to be quoted.
As an example we were generating something like this:
```
 os_hypervisors_with_servers:
 in: query
 name: with_servers
 schema:
 type:
 - boolean
 - string
 enum:
 - true
 - 'True'
 - 'TRUE'
 - 'true'
 - '1'
 - ON
 - On
 - on
 - YES
 - Yes
 - yes
 - false
 - 'False'
 - 'FALSE'
 - 'false'
 - '0'
 - OFF
 - Off
 - off
 - NO
 - No
 - no
 x-openstack:
 min-ver: '2.53'
```
Which is incorrectly interpreted by PyYAML like this:
```
 enum:
 - true
 - 'True'
 - 'TRUE'
 - 'true'
 - '1'
 - true
 - true
 - true
 - true
 - true
 - true
 - false
 - 'False'
 - 'FALSE'
 - 'false'
 - '0'
 - false
 - false
 - false
 - false
 - false
 - false ```
```
To fix this we enable our tool to output the specs in v1.1 with a new
parameter `--yaml-version` so that when it's set to 1.1 it will quote
all booleans that in v1.1 could be misinterpreted.
[1]: https://pypi.org/project/PyYAML/
Change-Id: I7236f6a94ccb2e92a086c16895efa4dc557460c4

Currently we comment the operation_name attribute in the metadata that
it is used as an action name. This only creates confusion especially if
we want to use something different as the operation_name (i.e.
operation_name or opertaion_type for neutron router results in
"action"). So in addition to the renaming of the metadata attribute
explicitly pass the metadata operation key as operation_name parameters
into the generator (when unset).
Change-Id: Ic04eafe5b6dea012ca18b9835cd5c86fefa87055
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

In the metadata operation_name may be empty. In the cli output processor
we should fallback to the operation_type when operation_name is empty.
Change-Id: Ib7aebca1a6e5982ea5fa32c7dfe62fd382689cc9
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

Using operation_type is not correct since it is simply "action" often.
Use the `operation_name` instead as we use in the metadata.
Change-Id: I8395df6816d9db25d9395b4372878abeab9c4110

Switch to the new cli OutputProcessor initialization interface with
resource_key and oepration_type parameters for enabling command specific
hints.
Change-Id: I67eaef1fd5f9f1ed72a5f11a23e8559739792f8a
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

Change-Id: I93d5520bc67135db9b0ac9da40dbfb587cb9acad
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

Change-Id: Ifcd98f8533fe4403c1ff8299bd08ce45bfdb60b9
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

User schema in keystone is now good enough. Drop the hardcode.
Change-Id: I718906b0c9c12fd4c7936bdb5047725fa3267b39
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

Fix typo "market" where "marker" should be.
Change-Id: Ic9f94727b6abb33619bde96a610fedad7cc12398

`prop: {const: True}` should be converted to bool and not to integer.
Change-Id: Ic3775a36c138d451dbad7615bc0e446528d8b0be
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

In swift we service return few integer attributes which can only be
positive. Ensure this is incorporated in the schema.
Change-Id: I23509ca116f607a2b26fa1c01387dbd4f4df705a
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>

When attribute is being locally renamed we miss the serde macros causing
deserialization to fail.
Change-Id: Ia8d8298c938ea088d1db62bf97df6defc41d93bc

Sort openapi spec to make it possible to put them under the version
control not taking care of changed ordering.
Change-Id: Ifb999f85a6d77e751cba8587c516c7d2c5c23644

In the cli generation it was assumed that the first element in the
response schema is the object itself. That is used to check whether the
response is list or not. Now the role_assignment schema return `links`
object first breaking that assumption. Extend the check to first look at
the `response_key` that we identified previously.
Change-Id: Ib2cf6e394486ebd0a475ed3d9bba97feefcd5205

Sometimes (and now very often) there is some race in the deep nested
structures rename handling. Apparently during renaming the wrong object
was modified causing it not to find referred entity later causing some
confusions depending on the order in which entities are processed.
Additionally when enum with the same name occur we should also look
whether the schema hash equals, in which case it is safe to simply skip
the schema completely).
Change-Id: I1bbb5f1e4f702ab54f72cdb70418b04567047187

For primitive types (not arrays and not dicts or similar) when resource
attribute can be explicitly nullable (while also being optional) it is
necessary to allow CLI user to set it to null. The only practical way
found till now is to add additional argument: `device_id / no_device_id`
which can be used to set explicit null. Neither relying on specific
value ("", "null") nor using default value when no value is sustainable
looking at the variations of APIs.
Change-Id: I6d549ffcc5c51a9c3ed849c590777b5ba4f6d721

Some conversion schemes missed explicit null support.
Change-Id: I01ed16f2690c78492a0d8673ad86f67de92c80ae

image in the server response may be an empty string if the server was
provisioned from a volume.
Change-Id: I4ec1d5391d373ec1aaba40b0547b06ebc9629ec2

On the response admin_state_up can be only boolean
Change-Id: I2d991491dbc5a97e36446a6d29c52b653b5a1657

port_details is an object and not array of objects.
Change-Id: I4095e664d714222d1d1ef8fdac0422393e7c451b

Change-Id: I8f394639f3272d4385618dda6731880e02e85a4e

Change-Id: I652e8b85632789d5172593154ddd9fef7508f359

In order to do more tests of the sdk/cli/types it is necessary to have a
convenient access to the source openapi spec. Copy this into the
`openstack_types/data`.
Change-Id: Ica1849dc81e77d05f277a14bb00030485c704ba2

Next step of enabling CLI output configuration. This time we add
resource_key into the generated CLI code so that we can map config
entries.
Change-Id: I43460adb71c18516c65ae20cf29a0a42a201a01f

- keypair create response does not contain ID
- server create response has a response_key (server). This is not really
 true, since creation may return reservation_id, but this is not
 typical and we can try to find a solution for that later. For now make
 sure cli server creation works.
Change-Id: I3f52f0e6686767dcc8862543c4c3a155f42ead0e