-
Notifications
You must be signed in to change notification settings - Fork 8.2k
west: spdx: Fix copyright parsing #98416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
11521d1 to
d618b0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you have a bug reference which is great but a brief summary of the issue in the commit message itself would not hurt. If you could also make the commit subject a bit more specific, even better! Admittedly very difficult in just one line and so few characters.
I see you have a bug reference which is great but a brief summary of the issue in the commit message itself would not hurt. If you could also make the commit subject a bit more specific, even better! Admittedly very difficult in just one line and so few characters.
Not sure if it's a good idea, but what do you think about squashing the two commits together?
I see you have a bug reference which is great
Actually, I just noticed you link to the bug only in the github description. Making this part of the commit message and git history is better.
Not sure if it's a good idea, but what do you think about squashing the two commits together?
I don't know; it depends on whether the first commit achieves something useful alone - without breaking anything of course. Does it?
Yeah first commit will break for people who have what's (at the time of writing) a previous REUSE release from up to (at the time of writing) just a few weeks ago so it's better to make it clear in the requirements file that a recent version is needed (unless copyright_notices was already there in < 6.0 but I don't think it was...)
Fix broken copyright parsing. Since REUSE 6.0.0 the copyright_lines attribute has been removed. The new attribute copyright_notices is used. Additionally, the python package REUSE should now be at least v0.6.0. This will require an update of REUSE for users that were using a version earlier than 0.6. Fixes zephyrproject-rtos#98378 Signed-off-by: Simone Orru <simone.orru@secomind.com>
d618b0e to
c73a4f8
Compare
@kartben No, the CopyrightNotice class has been added in 6.0
I rebased and pushed the single commit form.
Quality Gate Passed Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Fix the copyright parsing bug resulting from the new REUSE API. See the related issue for more information on the API change from v0.5.x and v0.6.x in REUSE.
Fixes #98378