Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DNM] manifest: Make ArduinoCore-API a downloadable blob #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
soburi wants to merge 2 commits into zephyrproject-rtos:next
base: next
Choose a base branch
Loading
from soburi:blob

Conversation

@soburi
Copy link
Member

@soburi soburi commented Nov 1, 2025

Make the license-incompatible headers and implementations
a downloadable blob using west blobs fetch.

@soburi soburi added the DNM This PR should not be merged (Do Not Merge) label Nov 1, 2025
@soburi soburi force-pushed the blob branch 2 times, most recently from 2b822a5 to fa24435 Compare November 1, 2025 08:27
@soburi soburi changed the title (削除) manifest: Make ArduinoCore-API a downloadable blob (削除ここまで) (追記) [DNM] manifest: Make ArduinoCore-API a downloadable blob (追記ここまで) Nov 1, 2025
Copy link
Member

This is something similar to how @kartben was suggesting here zephyrproject-rtos/zephyr#97726 right?

Copy link
Member Author

soburi commented Nov 2, 2025
edited
Loading

This is something similar to how @kartben was suggesting here zephyrproject-rtos/zephyr#97726 right?

Probably not.
This brings in ArduinoCore-API related files as blobs from outside easily.
This may not be necessary if you are making this an external module.
Rather, this is fit for a case that treats this repo as "Disabled Module."

This mechanism is intended to prevent sources with incompatible licenses from being included in this repository. I believe it qualifies for integration into Zephry, at least from the licensing perspective.

DhruvaG2000 reacted with thumbs up emoji

soburi added 2 commits November 2, 2025 20:06
Make the license-incompatible headers and implementations
a downloadable blob using `west blobs fetch`.
Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Since ArduinoCore-API has been made into a blob,
the CI procedure will be modified.
Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DhruvaG2000 DhruvaG2000 Awaiting requested review from DhruvaG2000 DhruvaG2000 will be requested when the pull request is marked ready for review DhruvaG2000 is a code owner

@szczys szczys Awaiting requested review from szczys szczys will be requested when the pull request is marked ready for review szczys is a code owner

@beriberikix beriberikix Awaiting requested review from beriberikix beriberikix will be requested when the pull request is marked ready for review beriberikix is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

DNM This PR should not be merged (Do Not Merge)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /