-
Notifications
You must be signed in to change notification settings - Fork 48
Move interrupts and noInterrupts out of namespace #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Ayush1325
Copy link
Member
@Ayush1325
Ayush1325
commented
Sep 5, 2024
- These functions are exported from Arduino.h
- Fixes Implement interrupts and noInterrupts #119
soburi
soburi
reviewed
Sep 6, 2024
cores/arduino/zephyrCommon.cpp
Outdated
}
}
static unsigned int irq_key;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In C++, you should use anonymous namespace instead of static.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For functions as well? Because I get undefined reference errors if I move functions into the anonymous namespace
- These functions are exported from Arduino.h Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@Ayush1325
Ayush1325
force-pushed
the
interrupts-fix
branch
from
September 6, 2024 15:14
a5ce724 to
ff3e1e8
Compare
soburi
soburi
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.