Fix UUID splitting #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

sparrc merged 1 commit into master from fix-uuid

Mar 5, 2018

Merged

Fix UUID splitting #45

sparrc merged 1 commit into master from fix-uuid

Mar 5, 2018

Conversation

@sparrc

Copy link

Contributor

@sparrc sparrc commented Mar 2, 2018

No description provided.

@sparrc sparrc force-pushed the fix-uuid branch from 885f8de to d1c06e4 Compare

March 2, 2018 15:12

sparrc

sparrc commented

Mar 2, 2018

View reviewed changes

mpd/duration.go

func (d Duration) MarshalXMLAttr(name xml.Name) (xml.Attr, error) {

return xml.Attr{name, d.String()}, nil

return xml.Attr{Name: name,Value: d.String()}, nil

Copy link

Contributor Author

@sparrc sparrc Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated linting fix

@coveralls

Copy link

coveralls commented Mar 2, 2018 •

edited

Loading

Coverage Status

Coverage decreased (-0.08%) to 80.245% when pulling cd2b164 on fix-uuid into 90d0544 on master.

stuarthicks

stuarthicks reviewed

Mar 2, 2018

View reviewed changes

mpd/mpd_test.go Outdated

s, _ := m.AddNewAdaptationSetVideo("7357", DASH_MIME_TYPE_VIDEO_MP4, VALID_SCAN_TYPE, VALID_SEGMENT_ALIGNMENT, VALID_START_WITH_SAP)

cp, err := s.AddNewContentProtectionRoot("")

cp, err := s.AddNewContentProtectionRoot2("")

Copy link

Contributor

@stuarthicks stuarthicks Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we come up with a more descriptive name please?

Copy link

Contributor

@philcluff philcluff Mar 2, 2018 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AddNewContentProtectionRootThatDoesntMisformatUUIDs ?

Copy link

Contributor Author

@sparrc sparrc Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AddNewContentProtectionRootFixedUUID?

@mbowBC

Copy link

Contributor

mbowBC commented Mar 2, 2018 •

edited

Loading

Think one test for the old AddNewContentProtectionRoot needs to be left in.

thomshutt

thomshutt approved these changes

Mar 5, 2018

View reviewed changes

@sparrc


 Fix UUID splitting

cd2b164

@sparrc sparrc force-pushed the fix-uuid branch from d58f05f to cd2b164 Compare

March 5, 2018 13:08

@sparrc sparrc merged commit cd2b164 into master

Mar 5, 2018

@sparrc sparrc deleted the fix-uuid branch

March 5, 2018 13:08

Labels

None yet

7 participants

@sparrc @coveralls @mbowBC @philcluff @stuarthicks @thomshutt

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix UUID splitting #45

Fix UUID splitting #45

Uh oh!

Conversation

@sparrc sparrc commented Mar 2, 2018

Uh oh!

@sparrc sparrc Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

coveralls commented Mar 2, 2018 •

edited

Loading

Uh oh!

Uh oh!

@stuarthicks stuarthicks Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

@philcluff philcluff Mar 2, 2018 •

edited

Loading

Uh oh!

Choose a reason for hiding this comment

Uh oh!

@sparrc sparrc Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

mbowBC commented Mar 2, 2018 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Fix UUID splitting #45

Fix UUID splitting #45

Uh oh!

Conversation

@sparrc sparrc commented Mar 2, 2018

Uh oh!

@sparrc sparrc Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

coveralls commented Mar 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

@stuarthicks stuarthicks Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

@philcluff philcluff Mar 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

@sparrc sparrc Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

mbowBC commented Mar 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

coveralls commented Mar 2, 2018 •

edited

Loading

@philcluff philcluff Mar 2, 2018 •

edited

Loading

mbowBC commented Mar 2, 2018 •

edited

Loading