Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Support HBBTV 1.5 in go-dash #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philcluff merged 4 commits into master from hbbtv-profile
Aug 16, 2016
Merged

Support HBBTV 1.5 in go-dash #31

philcluff merged 4 commits into master from hbbtv-profile
Aug 16, 2016

Conversation

@jyehbrightcove
Copy link
Contributor

@jyehbrightcove jyehbrightcove commented Aug 9, 2016 •
edited by philcluff
Loading

HbbTV changes. New Profile string. Audio Channel Configuration is in here now

brycefisher reacted with hooray emoji
Copy link

Coverage Status

Coverage increased (+8.05%) to 82.133% when pulling 0acf745 on hbbtv-profile into 1d88d19 on master.
brycefisher reacted with heart emoji

Copy link
Contributor

philcluff commented Aug 11, 2016 •
edited
Loading

Looks like TestFullHbbTVProfileWriteToString is failing on Circle.

@@ -0,0 +1,39 @@
<?xml version="1.0" encoding="UTF-8"?>
<MPD xmlns="urn:mpeg:dash:schema:mpd:2011" profiles="urn:hbbtv:dash:profile:isoff-live:2012" type="static" mediaPresentationDuration="PT6M16S" minBufferTime="PT1.97S">
Copy link
Contributor

@philcluff philcluff Aug 11, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For HBBTV 1.5, I believe you should define both the HBBTV profile, and the Live Profile, IE: urn:hbbtv:dash:profile:isoff-live:2012,urn:mpeg:dash:profile:isoff-live:2011

(Based on a look at what gets generated by Zencoder today for example)

Copy link
Contributor

A couple of comments and the test needs fixing, otherwise looks good.

@philcluff philcluff changed the title (削除) HbbTV changes. New Profile string. Audio Channel Configuration is i... (削除ここまで) (追記) Support HBBTV 1.5 in go-dash (追記ここまで) Aug 11, 2016
Copy link

Coverage Status

Coverage increased (+8.05%) to 82.133% when pulling 5594cbf on hbbtv-profile into 1d88d19 on master.

Copy link
Contributor

LGTM!

@philcluff philcluff merged commit 047bad4 into master Aug 16, 2016
@philcluff philcluff deleted the hbbtv-profile branch August 16, 2016 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /