-
Couldn't load subscription status.
- Fork 68
Adding support for SegmentTimeline and SegmentList #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding structs based off the DASH XSDs to support SegmentTimeline and SegmentList. Reworked existing structs to allow adding timelines and lists at different points in the manifest.
Renamed Intptr to Int64ptr since that is what it is and made a new Intptr func to deal with a normal int. Added a few others needed by the newer structs’ properties and updated touch points as needed.
mpd/segment.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is private and doesn't seem to be used anywhere, any reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note unrelated to your change: This certainly doesn't need to be an Int64
LGTM.
# Conflicts: # mpd/mpd.go Updated tests to have correct element order in AdaptationSet.
Adding support for SegmentTimeline and SegmentList
Work related to #26
Added in additional structs to model SegmentTimeline and SegmentList and updated Period, AdaptationSet and Representation to include them as options.