-
Notifications
You must be signed in to change notification settings - Fork 1k
Wraps chrome.storage with try/catch #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If anyone knows the correct typeof for chrome.storage.sync that we could check against, that would be cleaner than my current solution.
userlerueda
commented
Mar 1, 2022
@slapbox do you want to try to get this PR integrated in the new repo they posted to see if this can be fixed?
https://github.com/reduxjs/redux-devtools/blob/main/extension/src/browser/extension/options/syncOptions.ts
I can submit the change but since you were the one who spotted the problem.
@userlerueda if you have the bandwidth to resubmit this PR there, please do!
Fixes #767