Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Hash slotname, if it exceeds 63 characters in streams #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johannesknauft wants to merge 2 commits into zalando:master
base: master
Choose a base branch
Loading
from johannesknauft:fix_long_slot_name_in_streams

Conversation

@johannesknauft
Copy link
Member

@johannesknauft johannesknauft commented Nov 27, 2024
edited
Loading

The replication slot in Postgres is of type name, which has a char limit of 63. At the moment the inputs of the stream section are used to generate the slot name, they are constructed by combining fes_{dbname}_{app_id}. This easily can exceed 63 characters, as application ids tend to be longer in a microservice environment, and also db names can contain things like team-name, environment, and the same long app-id. To address this when using streams in the Postgres manifest, I created a PR that checks if this is the case and then hashes the slot name to ensure its length is always shorter than 63. This should result in the configuration not failing when applied.

I am also happy to discuss/implement other alternatives like:

  • Truncating
  • Shortening: long_application_id -> lai

chobostar reacted with thumbs up emoji
@FxKu FxKu added this to the 1.15.0 milestone Dec 23, 2024
@FxKu FxKu added the minor label Dec 23, 2024
@FxKu FxKu modified the milestones: 1.15.0, 1.16.0 Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@FxKu FxKu Awaiting requested review from FxKu FxKu is a code owner

@jopadi jopadi Awaiting requested review from jopadi jopadi is a code owner

@idanovinda idanovinda Awaiting requested review from idanovinda idanovinda is a code owner

@hughcapet hughcapet Awaiting requested review from hughcapet hughcapet is a code owner

@macedigital macedigital Awaiting requested review from macedigital

Assignees

No one assigned

Labels

Projects

Status: Waiting for review

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /